Skip to content

Commit 2eeb2d5

Browse files
committedJun 8, 2017
Include revision title in output of GET /revision/{id}
The title of a revision is very important, but, accidentally I left it out when I initially created the revision api.
1 parent 6f88b8c commit 2eeb2d5

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed
 

‎landoapi/api/revisions.py

+1
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ def _format_revision(
9191
return {
9292
'id': int(revision['id']),
9393
'phid': revision['phid'],
94+
'title': revision['title'],
9495
'url': revision['uri'],
9596
'date_created': int(revision['dateCreated']),
9697
'date_modified': int(revision['dateModified']),

‎landoapi/spec/swagger.yml

+4
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,10 @@ definitions:
6464
type: string
6565
description: |
6666
The phid of the revision.
67+
title:
68+
type: string
69+
description: |
70+
The title of the revision.
6771
url:
6872
type: string
6973
description: |

‎tests/canned_responses/lando_api/revisions.py

+2
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
},
2525
"status": 1,
2626
"status_name": "Needs Revision",
27+
"title": "My test diff 1",
2728
"summary": "Summary 1",
2829
"test_plan": "Test Plan 1",
2930
"url": "https://mozphab.dev.mozaws.net/D1"
@@ -53,6 +54,7 @@
5354
},
5455
"status": 1,
5556
"status_name": "Needs Revision",
57+
"title": "My test diff 2",
5658
"summary": "Summary 2",
5759
"test_plan": "Test Plan 2",
5860
"url": "https://mozphab.dev.mozaws.net/D2"

0 commit comments

Comments
 (0)
Failed to load comments.