Make the project Dockerflow compliant and build it in CircleCI #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lock down the packages in dev-requirements.txt with hashes, same as we have it in the lando-ui project.
Add a docker-compose.yml, docker images, and README instructions for development. Also add a Dockerfile for production.
Add API endpoints so we conform to Cloud Ops' Dockerflow spec.
Added standard project boilerplate so CI runs our tests on commit and also builds production-ish docker images. A bunch of extra tasks for conveniently developing the project come along with the tasks.py file.
purelogiq
suggested changes
May 3, 2017
There was a problem hiding this comment.
Everything looks good - except 1 thing. Can you add the these tests: https://github.com/mozilla-conduit/lando-ui/blob/master/tests/test_py3_codequality.py so that linting becomes part of the test suite itself like lando-ui?
Add code quality tests so they will run in (and fail) the CI test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the project using Docker, add Dockerflow API endpoints, and build everything with CircleCI. Most code was copied from the Lando UI project.