Break the unit test suite's reliance on os.environ #10
Conversation
Some unit tests won't run unless os.environ is set. Mock out the required environment variables so that the unit tests pass.
|
|
||
|
|
||
| @pytest.fixture | ||
| def docker_env_vars(monkeypatch): |
There was a problem hiding this comment.
There is a file tests/utils.py which contains utility and setup functions that every test uses. Can you move this function to that file? Unless there is a purpose for this file in the near future. I just want to avoid having a bunch of test setup across different files.
There was a problem hiding this comment.
Nevermind! I see that conftest.py is a common pattern with pytest.
| @@ -16,6 +16,8 @@ | |||
| from tests.canned_responses.phabricator.repos import * | |||
| from tests.canned_responses.phabricator.errors import * | |||
|
|
|||
| pytestmark = pytest.mark.usefixtures('docker_env_vars') | |||
There was a problem hiding this comment.
I believe that if you also move this to test/utils.py then we won't have to add it at the top of every test file, every test file can just import the utils file as they already do.
There was a problem hiding this comment.
Ignore the specifics above, but, otherwise is there a better way to have this be done automatically for every test?
There was a problem hiding this comment.
Importing the fixture won't apply it - you need to include a fixture in the module's pytestmark to apply it to every test in a file.
| @pytest.fixture | ||
| def docker_env_vars(monkeypatch): | ||
| """Monkeypatch environment variables that we'd get running under docker.""" | ||
| monkeypatch.setenv('PHABRICATOR_URL', 'http://phabricator.test') |
There was a problem hiding this comment.
If you're going to change the phab url, can you also go through and update all the canned responses to use this URL? Right now they use the default mozphab.aws URL which came from the original docker-compose.yml.
Some unit tests won't run unless os.environ is set. Mock out the
required environment variables so that the unit tests pass.