Use data factories for testing #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mars-f
force-pushed
the
wip-use-data-factories-for-testing
branch
4 times, most recently
from
530c955 to
9a86593
Compare
|
Does this invalidate #10? |
mars-f
force-pushed
the
wip-use-data-factories-for-testing
branch
from
02f291a to
f05743a
Compare
mars-f
changed the title
mars-f
force-pushed
the
wip-use-data-factories-for-testing
branch
from
f05743a to
81f20bc
Compare
|
@purelogiq #10 is still valid. |
Using carefully-crafted test data fixtures can lead to brittle tests and difficult-to-construct test scenarios in our integration tests. Switch the test suite to use a data factory instead of static fixtures to mock Phabricator responses.
mars-f
force-pushed
the
wip-use-data-factories-for-testing
branch
from
81f20bc to
9295ec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using carefully-crafted test data fixtures can lead to brittle tests and
difficult-to-construct test scenarios in our integration tests.
Switch the test suite to use a data factory instead of static fixtures
to mock Phabricator responses.