Add Alembic migrations using flask-alembic #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalun
force-pushed
the
add-migrations
branch
4 times, most recently
from
8981dd4 to
e56eb97
Compare
mars-f
suggested changes
Jun 27, 2017
| @@ -12,6 +12,8 @@ RUN apk --update --no-cache add \ | |||
| RUN mkdir /db | |||
| RUN chown app:app /db | |||
|
|
|||
| COPY migrations /migrations | |||
There was a problem hiding this comment.
Does this also need to be applied to Dockerfile-dev?
There was a problem hiding this comment.
It is linked in docker-compose
tasks.py
Outdated
| def create_db(ctx): | ||
| """Call `create_all` on a SQLAlchemy database.""" | ||
| @task | ||
| def revision(ctx, msg): |
There was a problem hiding this comment.
Can we rename this to something more intuitive, like add-migration? Running invoke add-migration to start a new migration from a template sounds more intuitive than invoke revision, especially if the developer isn't familiar with Alembic terminology.
zalun
changed the title
purelogiq
approved these changes
Jun 27, 2017
We're using Alembic with Flask-Alembic.
Added revision and upgrade manage.py commands.
Created a initialization migration.
Removed the schema file, `upgrade` is used to create the tables.
Use `invoke add-migration {name-of-revision}` to create a migration revision.
mars-f
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.