Use unbuffered stdout for containers #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use unbuffered stdout for all containers. In dev this makes print() statements work. In prod using unbuffered output for daemons is just plain good practice.
purelogiq
suggested changes
Jun 30, 2017
| @@ -11,6 +11,8 @@ CMD ["/usr/local/bin/uwsgi"] | |||
|
|
|||
| RUN addgroup -g 10001 app && adduser -D -u 10001 -G app -h /app app | |||
|
|
|||
| ENV PYTHONUNBUFFERED=1 | |||
There was a problem hiding this comment.
we don't need this in production. In production we will be using mozlog which doesn't have this problem. (And I'm unsure what this will do in production, do you think it is fine to have in prod??)
There was a problem hiding this comment.
Nevermind, I see your comment at the top!
There was a problem hiding this comment.
Yes, in prod it's even more important to not lose output because of a buffer. You never know when there will be a message in a buffer somewhere that's critical to debugging a problem, and you'll spend days pulling your hair out trying to figure out why there is no error message before the crash. 😄 😢
purelogiq
approved these changes
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use unbuffered stdout for all containers. In dev this makes print()
statements work. In prod using unbuffered output for daemons is just
plain good practice.