Fix looking up the correct image to push to dockerhub #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way we were looking for the image tag to push to dockerhub was an artifact of how were were pushing to dockerhub in our old conduit repo. The correct way is demonstrated in this commit, which smacleod has recommend and is consistent with how it is done in the mozphab repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we were looking for the image tag to push to dockerhub was an artifact of how were were pushing to dockerhub in our old conduit repo. The correct way is demonstrated in this commit, which smacleod has recommend and is consistent with how it is done in the mozphab repo.
When this PR is merged it should correctly push to our DockerHub repo here https://hub.docker.com/r/mozilla/lando-api/.
This has been fixed in the lando-ui repo by PR#3 there