Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix looking up the correct image to push to dockerhub #2

Merged
merged 1 commit into from
May 8, 2017
Merged

Fix looking up the correct image to push to dockerhub #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix looking up the correct image to push to dockerhub 
The way we were looking for the image tag to push to dockerhub was
an artifact of how were were pushing to dockerhub in our old conduit
repo. The correct way is demonstrated in this commit, which smacleod
has recommend and is consistent with how it is done in the mozphab repo
  • Loading branch information
@purelogiq
purelogiq committed May 8, 2017
commit 3f83e2e5cf989880f766247e5d2fd961d55d10a7
4 changes: 2 additions & 2 deletions circle.yml
View file
Original file line number Diff line number Diff line change
@@ -45,5 +45,5 @@ deployment:
commands:
- "[ ! -z $DOCKERHUB_REPO ]"
- docker login -e $DOCKER_EMAIL -u $DOCKER_USER -p $DOCKER_PASS
- "docker tag lando-api:build ${DOCKERHUB_REPO}:lando-api-${CIRCLE_SHA1}"
- "docker push ${DOCKERHUB_REPO}:lando-api-${CIRCLE_SHA1}"
- "docker tag ${DOCKERHUB_REPO} ${DOCKERHUB_REPO}:${CIRCLE_SHA1}"
- "docker push ${DOCKERHUB_REPO}:${CIRCLE_SHA1}"