Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return HTTP 502 from failed phabricator heartbeat checks #20

Merged

Conversation

mars-f
Copy link
Contributor

@mars-f mars-f commented Jun 30, 2017

To test this change, add the following to docker-compose.override.yml:

version: '2'
services:
  lando-api:
    environment:
      - PHABRICATOR_URL=https://nosuchhost.test

and hit http://:8888/heartbeat.

The container log should output a WARNING level message. It will not output INFO or DEBUG messages because we don't have the loggers configured for that yet (we should implement mozlogging instead).

@mars-f mars-f requested review from purelogiq, zalun and ckolos June 30, 2017 21:33
Copy link
Contributor

@purelogiq purelogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ckolos
Copy link

ckolos commented Jul 5, 2017

I have some concern about monitoring the health of phabricator from this application because phabricator being down doesn't result in a hard-down condition for lando. Whenever we do a phabricator deploy that will involve downtime (should only be schema changes), we will need to expect to receive an alert from lando reflecting that. I'm r+ on this right now with the understanding that we may wish to remove this in the future.

@purelogiq purelogiq merged commit dc7d946 into mozilla-conduit:master Jul 11, 2017
@mars-f mars-f deleted the phab-api-connectivity-check branch July 11, 2017 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants