Use mozlog for application logging #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purelogiq
suggested changes
Jul 5, 2017
zalun
approved these changes
Jul 5, 2017
zalun
approved these changes
Jul 11, 2017
purelogiq
suggested changes
Jul 11, 2017
Configure the application to use the mozlog structured log format for application-level log messages (log messages from libraries and frameworks still go through the Python Standard Library string logger).
purelogiq
approved these changes
Jul 11, 2017
landoapi/transplant_client.py
Outdated
| ldap_username, | ||
| 'msg': | ||
| 'received an empty response from the transplant service', | ||
| }, 'transplant.failure' |
There was a problem hiding this comment.
at the end of this line you can add a comment like: # yapf: disable to prevent the linter from formating this hash. I don't think this is good style just because the linter says so, it's clearly a bug and we know better :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure the application to use the mozlog structured log format for
application-level log messages (log messages from libraries and
frameworks still go through the Python Standard Library string logger).
To test, modify
docker-compose.override.ymland set theLOG_LEVELenvironment variable to the string valuedebug. A message about logging initialization should appear in the container logs.Try setting the
LOG_LEVELvalue tofoobarto see what happens if an unknown/typo'd log level is set.