Use default phabricator api key to query public revisions #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mars-f
suggested changes
Jun 7, 2017
landoapi/spec/swagger.yml
Outdated
| @@ -34,7 +34,7 @@ paths: | |||
| type: string | |||
| description: | | |||
| A Phabricator Conduit API key to use to get the revision. | |||
There was a problem hiding this comment.
Could you add a sentence here to say that, if this value is left out, a key only capable of working with public revisions will be used instead?
landoapi/api/revisions.py
Outdated
| @@ -5,11 +5,13 @@ | |||
| Revision API | |||
| See the OpenAPI Specification for this API in the spec/swagger.yml file. | |||
| """ | |||
| import os | |||
There was a problem hiding this comment.
The os module isn't used in the rest of the patch - an unused import?
purelogiq
force-pushed
the
plq/optional-api-key
branch
2 times, most recently
from
476abc2 to
b1fe868
Compare
After a long talk with our security folks, we came to a conclusion that having every user of Lando (1000+) enter their Phabricator API keys would be a possible security risk, even if stored in a secure cookie. This patch allows Lando to use 1 key that it owns itself to query for public revisions on behalf of users. If the user does provide an api key, that key will be used instead, which allows users who have access to secure revisions to only input their API key when needed.
purelogiq
force-pushed
the
plq/optional-api-key
branch
from
b1fe868 to
f795b4a
Compare
mars-f
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a long talk with our security folks, we came to a conclusion that having every user of Lando (1000+) enter their Phabricator API keys would be a possible security risk, even if stored in a secure cookie.
This patch allows Lando to use 1 key that it owns itself to query for public revisions on behalf of users. If the user does provide an api key, that key will be used instead, which allows users who have access to secure revisions to only input their API key when needed.