Bug 1744105 - Please update Phabricator to 2021 Week 49 (20211202.1)

Dockerfile

@@ -93,7 +93,7 @@ COPY --chown=app scripts phabricator/scripts
 COPY --chown=app src phabricator/src
 COPY --chown=app support phabricator/support
 COPY --chown=app webroot phabricator/webroot
-RUN git clone https://github.com/mozilla-conduit/arcanist arcanist \
+RUN git clone https://github.com/mozilla-conduit/arcanist -b stable arcanist \
     && ./arcanist/support/xhpast/build-xhpast.php
 
 # Install Python dependencies

NOTICE

@@ -1,7 +1,7 @@
 Phabricator
 Copyright 2014 Phacility, Inc.
 
-This software is primarily developed and maintained by Phacility, Inc.
+Phabricator was originally developed and maintained by Phacility, Inc.
 
   http://www.phacility.com/
 

entrypoint.sh

@@ -148,7 +148,7 @@ case "$ARG" in
       ;;
   "arc_liberate")
 	    cd /app/moz-extensions/
-	    /app/arcanist/bin/arc liberate src/
+	    /app/arcanist/bin/arc liberate src/ --
 	    ;;
   "test_phab")
 	    # Find all extension tests and call them

resources/celerity/map.php

@@ -9,8 +9,8 @@
   'names' => array(
     'conpherence.pkg.css' => '0e3cf785',
     'conpherence.pkg.js' => '020aebcf',
-    'core.pkg.css' => '0ae696de',
-    'core.pkg.js' => '68f29322',
+    'core.pkg.css' => '00a2e7f4',
+    'core.pkg.js' => 'd2de90d9',
     'dark-console.pkg.js' => '187792c2',
     'differential.pkg.css' => 'ffb69e3d',
     'differential.pkg.js' => '8deec4cd',
@@ -171,7 +171,7 @@
     'rsrc/css/phui/phui-invisible-character-view.css' => 'c694c4a4',
     'rsrc/css/phui/phui-left-right.css' => '68513c34',
     'rsrc/css/phui/phui-lightbox.css' => '4ebf22da',
-    'rsrc/css/phui/phui-list.css' => '2f253c22',
+    'rsrc/css/phui/phui-list.css' => '0c04affd',
     'rsrc/css/phui/phui-object-box.css' => 'b8d7eea0',
     'rsrc/css/phui/phui-pager.css' => 'd022c7ad',
     'rsrc/css/phui/phui-pinboard-view.css' => '1f08f5d8',
@@ -246,7 +246,7 @@
     'rsrc/externals/javelin/ext/view/__tests__/ViewInterpreter.js' => 'a9f35511',
     'rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js' => '3a1b81f6',
     'rsrc/externals/javelin/lib/Cookie.js' => '05d290ef',
-    'rsrc/externals/javelin/lib/DOM.js' => '94681e22',
+    'rsrc/externals/javelin/lib/DOM.js' => 'e4c7622a',
     'rsrc/externals/javelin/lib/History.js' => '030b4f7a',
     'rsrc/externals/javelin/lib/JSON.js' => '541f81c3',
     'rsrc/externals/javelin/lib/Leader.js' => '0d2490ce',
@@ -717,7 +717,7 @@
     'javelin-color' => '78f811c9',
     'javelin-cookie' => '05d290ef',
     'javelin-diffusion-locate-file-source' => '94243d89',
-    'javelin-dom' => '94681e22',
+    'javelin-dom' => 'e4c7622a',
     'javelin-dynval' => '202a2e85',
     'javelin-event' => 'c03f2fb4',
     'javelin-external-editor-link-engine' => '48a8641f',
@@ -872,7 +872,7 @@
     'phui-invisible-character-view-css' => 'c694c4a4',
     'phui-left-right-css' => '68513c34',
     'phui-lightbox-css' => '4ebf22da',
-    'phui-list-view-css' => '2f253c22',
+    'phui-list-view-css' => '0c04affd',
     'phui-object-box-css' => 'b8d7eea0',
     'phui-oi-big-ui-css' => 'fa74cc35',
     'phui-oi-color-css' => 'b517bfa0',
@@ -1781,13 +1781,6 @@
       'javelin-uri',
       'javelin-routable',
     ),
-    '94681e22' => array(
-      'javelin-magical-init',
-      'javelin-install',
-      'javelin-util',
-      'javelin-vector',
-      'javelin-stratcom',
-    ),
     '9623adc1' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -2167,6 +2160,13 @@
       'javelin-dom',
       'phuix-dropdown-menu',
     ),
+    'e4c7622a' => array(
+      'javelin-magical-init',
+      'javelin-install',
+      'javelin-util',
+      'javelin-vector',
+      'javelin-stratcom',
+    ),
     'e5bdb730' => array(
       'javelin-behavior',
       'javelin-stratcom',

resources/sprite/manifest/login.json

@@ -59,7 +59,7 @@
     "login-MediaWiki": {
       "name": "login-MediaWiki",
       "rule": ".login-MediaWiki",
-      "hash": "f1f0a9382434081a9a84e7584828c2dd"
+      "hash": "68eba44e85ea942ecf14d3c08992a2e2"
     },
     "login-PayPal": {
       "name": "login-PayPal",

resources/sql/autopatches/20210713.harborcommand.01.migrate.sql

@@ -0,0 +1,4 @@
+INSERT IGNORE INTO {$NAMESPACE}_harbormaster.harbormaster_buildmessage
+  (authorPHID, receiverPHID, type, isConsumed, dateCreated, dateModified)
+  SELECT authorPHID, targetPHID, command, 0, dateCreated, dateModified
+    FROM {$NAMESPACE}_harbormaster.harbormaster_buildcommand;

resources/sql/autopatches/20210713.harborcommand.02.drop.sql

@@ -0,0 +1 @@
+DROP TABLE IF EXISTS {$NAMESPACE}_harbormaster.harbormaster_buildcommand;

resources/sql/autopatches/20210715.harborcommand.01.xactions.php

@@ -0,0 +1,34 @@
+<?php
+
+// See T13072. Turn the old "process a command" transaction into modular
+// transactions that each handle one particular type of command.
+
+$xactions_table = new HarbormasterBuildTransaction();
+$xactions_conn = $xactions_table->establishConnection('w');
+$row_iterator = new LiskRawMigrationIterator(
+  $xactions_conn,
+  $xactions_table->getTableName());
+
+$map = array(
+  '"pause"' => 'message/pause',
+  '"abort"' => 'message/abort',
+  '"resume"' => 'message/resume',
+  '"restart"' => 'message/restart',
+);
+
+foreach ($row_iterator as $row) {
+  if ($row['transactionType'] !== 'harbormaster:build:command') {
+    continue;
+  }
+
+  $raw_value = $row['newValue'];
+
+  if (isset($map[$raw_value])) {
+    queryfx(
+      $xactions_conn,
+      'UPDATE %R SET transactionType = %s WHERE id = %d',
+      $xactions_table,
+      $map[$raw_value],
+      $row['id']);
+  }
+}

resources/sql/patches/20131004.dxreviewers.php

@@ -29,8 +29,7 @@
   foreach ($reviewer_phids as $dst) {
     if (phid_get_type($dst) == PhabricatorPHIDConstants::PHID_TYPE_UNKNOWN) {
       // At least one old install ran into some issues here. Skip the row if we
-      // can't figure out what the destination PHID is. See here:
-      // https://github.com/phacility/phabricator/pull/507
+      // can't figure out what the destination PHID is.
       continue;
     }