Bug 1758000: use repo root and Phabricator repo IDs to retrieve callsign #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we referenced `.arcconfig` to determine the callsign for the given repo. Instead we check the location of `repo.root` for an ID number which we reference against the ID value from a search against `diffusion.repository.search`.
|
@zzzeid this seems to work, though I can't concretely test it in suite. |
zzzeid
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
lgtm -- should test on dev if you can't test reliably on local suite though. Easiest way to test this is to manually push commits to remote repos that have a differential revision line, so the workflow gets triggered (there's a test-repo-clone repo for this purpose).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we referenced
.arcconfigto determine the callsignfor the given repo. Instead we check the location of
repo.rootfor an ID number which we reference against the ID value from
a search against
diffusion.repository.search.