Bug 1758000: decode repo.root to str before passing to Path
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pathlib` doesn't work with bytes paths, so we need to decode `repo.root` before creating the `Path` object. While we are here, update the docstring to reflect the new behaviour of the function and use the correct `%d` string formatting operator.
|
Maybe we should add simple smoke-test for Either way I'm hopeful this is the last |
zzzeid
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathlibdoesn't work with bytes paths, so we need to decoderepo.rootbefore creating thePathobject.While we are here, update the docstring to reflect the new
behaviour of the function and use the correct
%dstringformatting operator.