Bug 1760933: return a str from get_phab_server_callsign
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had incorrect type annotations on both callsign fetching functions, so changing one function to actually return `str` resulted in inconsistent types when comparing otherwise identical strings. Stop encoding the value of `get_phab_server_callsign` and only encode to `bytes` once we need to send the string off to Mercurial. Also use a different variable name for the encoded JSON `params` to avoid changing the type from `dict` and yielding a warning from linters.
zzzeid
approved these changes
Mar 24, 2022
|
Tested in suite and a revision in the same repo is left without a modified commit message, differential revision correctly closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had incorrect type annotations on both callsign
fetching functions, so changing one function to actually
return
strresulted in inconsistent types when comparingotherwise identical strings. Stop encoding the value of
get_phab_server_callsignand only encode tobytesoncewe need to send the string off to Mercurial.
Also use a different variable name for the encoded JSON
paramsto avoid changing the type fromdictand yieldinga warning from linters.