Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1770744 - Show spinner in place of Done checkbox during waiting for server response. #23

Merged
merged 1 commit into from
May 24, 2022

Conversation

arai-a
Copy link

@arai-a arai-a commented May 23, 2022

No description provided.

@arai-a
Copy link
Author

arai-a commented May 23, 2022

for bug 1770744

After clicking the "Done" checkbox, show a spinner icon, and hide the checkbox,
and once the response is received and when the checkbox state is going to be updated, hide the spinner icon and show the checkbox.

@arai-a
Copy link
Author

arai-a commented May 24, 2022

Here's the preview for the transition.

done-check

@dklawren dklawren self-requested a review May 24, 2022 21:06
Copy link
Collaborator

@dklawren dklawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. r=dkl

@dklawren dklawren merged commit 903a7c2 into mozilla-conduit:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants