Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1472174 - Linkify the bug number in the commit message in the revision page. #30

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

arai-a
Copy link

@arai-a arai-a commented Jun 4, 2022

This is dirty hack that directly modifies the code that's not BMO-specific.
If this is not acceptable, I'll look into make it more generic, like comment markup.

Also, for some reason, a link in the header has almost same color as the header itself (#464C5C vs #000000),
and it's hard to notice it's a link, so I added extra rule to make the link more visible.

Copy link
Collaborator

@dklawren dklawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. r=dkl

@dklawren dklawren merged commit 09d1d1c into mozilla-conduit:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants