Bug 1787517: include stack dependencies in revision #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzeid
changed the title
zzzeid
force-pushed
the
zeid/bug-1787517-show-stack-in-revision
branch
2 times, most recently
from
96d7d5c to
79f8c46
Compare
zzzeid
changed the title
zzzeid
commented
Aug 30, 2022
cgsheeh
requested changes
Aug 30, 2022
Comment on lines
1136
to
1137
| 'depends_on' => $stack_graph->getEdges(DifferentialRevisionDependsOnRevisionEdgeType::EDGECONST,), | ||
| 'dependents' => $stack_graph->getEdges(DifferentialRevisionDependedOnByRevisionEdgeType::EDGECONST), |
There was a problem hiding this comment.
Could we make this depended_on to stay consistent with the Phab terminology?
zzzeid
commented
Aug 30, 2022
cgsheeh
approved these changes
Aug 30, 2022
I do agree that they are the best terms out there but now that I think about it more, perhaps it should say But perhaps back on the Lando side we should use predecessors/successors. |
cgsheeh
approved these changes
Aug 30, 2022
This change will help Lando calculate stack graph without making repeated requests to the `edge.search` endpoint. A similar approach is already used in Phabricator when loading the revision page.
zzzeid
force-pushed
the
zeid/bug-1787517-show-stack-in-revision
branch
from
f2c975b to
d1f0800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will help Lando calculate stack graph without making
repeated requests to the
edge.searchendpoint. A similar approach isalready used in Phabricator when loading the revision page.