Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1787517: include stack dependencies in revision #32

Merged
merged 1 commit into from
Oct 25, 2022
+6 −0
Merged

Bug 1787517: include stack dependencies in revision #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Bug 1787517: include stack dependencies in revision 
This change will help Lando calculate stack graph without making
repeated requests to the `edge.search` endpoint. A similar approach is
already used in Phabricator when loading the revision page.
  • Loading branch information
@zzzeid
zzzeid committed Oct 13, 2022
commit d1f08001fc4b8c6b4a2a50ffdc12386e6223632c
6 changes: 6 additions & 0 deletions src/applications/differential/storage/DifferentialRevision.php
View file
Original file line number Diff line number Diff line change
@@ -1127,7 +1127,13 @@ public function getFieldValuesForConduit() {
'color.ansi' => $status->getANSIColor(),
);

$stack_graph = id(new DifferentialRevisionGraph())
->setSeedPHID($this->getPHID())
->setLoadEntireGraph(true)
->loadGraph();

return array(
'stackGraph' => $stack_graph->getEdges(DifferentialRevisionDependsOnRevisionEdgeType::EDGECONST,),
'title' => $this->getTitle(),
'uri' => PhabricatorEnv::getURI($this->getURI()),
'authorPHID' => $this->getAuthorPHID(),