Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no bug - Update Phabricator to Upstream 2023 Week 7 #36

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Conversation

dklawren
Copy link
Collaborator

No description provided.

epriestley added 3 commits February 27, 2023 14:12
Summary: See <https://hackerone.com/reports/1584409>. This obsolete API method is technically policy-violating: Owners packages have had policies since D15275. See also T10360.

Test Plan: Viewed Conduit API console, no longer saw API method available.

Differential Revision: https://secure.phabricator.com/D21850
…isabling global builtin queries

Summary: See <https://hackerone.com/reports/1573143>. The pathway for disabling global builtin queries is missing a policy check. Add it.

Test Plan:
  - Accessed the "/search/delete/id/.../" URI for a global builtin query as a non-administrator.
  - Before patch: could improperly disable queries.
   -After patch: proper policy exception.

Differential Revision: https://secure.phabricator.com/D21851
Summary: Ref T13682. After some change prior change likely connected to T13682, file PHIDs fail to extract properly in Pholio.

Test Plan:
  - Created a new Pholio mock with at least one image.
  - Before: fatal when extracting data from this datastructure.
  - After: clean mock creation.

Maniphest Tasks: T13682

Differential Revision: https://secure.phabricator.com/D21858
@dklawren dklawren merged commit c869010 into master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant