Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1944522 - Add Content-Type header option in Harbormaster HTTP Build step #46

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

La0
Copy link

@La0 La0 commented Jan 29, 2025

Bug 1944522

This PR adds an option to the Harbormaster HTTP Build Step to send an extra Content-Type header.

The current behaviour is preserved by default: no Content-Type header is sent.

Screenshot 2025-01-29 at 22-16-49 ♻ Make HTTP Request

I was able to test these changes locally, querying my own machine through a public IP from the docker container.
Using a debug server, I logged the headers sent by Phabricator when triggering manually a build plan:

Accept: */*
Content-Type: application/json;test-bastien
Accept-Encoding: gzip
Content-Length: 0

@globau globau changed the title Add Content-Type header option in Harbormaster HTTP Build step Bug 1944522 - Add Content-Type header option in Harbormaster HTTP Build step Jan 29, 2025
@dklawren dklawren self-requested a review January 29, 2025 22:17
@La0 La0 force-pushed the json-content-type branch from 87cbbcd to c6c977f Compare January 30, 2025 08:45
@La0
Copy link
Author

La0 commented Jan 30, 2025

I rebased on top of #47 to get a CircleCI run

@La0 La0 force-pushed the json-content-type branch from c6c977f to d7536d6 Compare January 30, 2025 16:36
@dklawren dklawren merged commit b2487f5 into mozilla-conduit:master Jan 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants