Bug 1944522 - Add HTTP Body option in Harbormaster HTTP Build step #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dklawren Could you take a look at this followup please ? |
|
Sorry I missed this before. I will take a look at it now. |
dklawren
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup of #46 to support an optional HTTP Body in the Harbormaster HTTP Build step.
Using this PR, I'm able to trigger a Taskcluster hook without any change on Taskcluster.
Here is the build step configuration I'm using:
Using the JSON Content-Type header with a JSON payload, I can provide the Harbormaster build target and other variables using the same
mergeVariablesas for URI formatting.There is no parsing nor validation whatsoever, it is the responsibility of the Build Step author to write a valid payload.
On Taskcluster: