Bug 1738776: put moz-extensions directory into a volume and mount into the test environment #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the test environment Add the `moz-extensions/` directory as a Docker volume and mount that volume into the test container. This makes `docker-compose run test_phab` use the code local to the working directory allowing for faster iteration when testing. We also unset `restart-failure` in the test environment as this causes the container to restart when any test fails, however the container can't restart and hangs around.
dklawren
approved these changes
Nov 3, 2021
|
Heads up that this broke Phabricator's CI job to test commits. |
|
Yeah. Let's back out for now. It worked locally (obviously) but is not happy in CI environment. |
|
Boo. I guess we could create a new |
|
Reverted, |
cgsheeh
added a commit
to cgsheeh/phabricator
that referenced
this pull request
Nov 5, 2021
…o the test environment This commit is the same content as mozilla-conduit#8, but the content is pasted into a new docker-compose service instead of overwriting `test_phab` which is used in CI.
cgsheeh
added a commit
to cgsheeh/phabricator
that referenced
this pull request
Dec 30, 2021
…o the test environment This commit is the same content as mozilla-conduit#8, but the content is pasted into a new docker-compose service instead of overwriting `test_phab` which is used in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
moz-extensions/directory as a Dockervolume and mount that volume into the test container.
This makes
docker-compose run test_phabuse thecode local to the working directory allowing for
faster iteration when testing.
We also unset
restart-failurein the test environmentas this causes the container to restart when any test
fails, however the container can't restart and hangs
around.