Migrate sync to gcpv2 #1654
Open
Migrate sync to gcpv2 #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
well, I guess it blew up! |
jrconlin
reviewed
Mar 19, 2025
.circleci/config.yml
Outdated
| parameters: | ||
| image: | ||
| type: string | ||
| default: us-docker.pkg.dev/my-gcp-project-id/my-gar-repo/my-image |
There was a problem hiding this comment.
This value feels very "template-y" is it supposed to be or should it have more "real" values?
jrconlin
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Circle CI build/deploy steps to work with GCPv2/MozCloud
Instructions from: https://mozilla-hub.atlassian.net/wiki/spaces/CS1/pages/997163545/Publishing+Container+Images+to+GAR
Testing
Create a tag and see if anything blows up - or, hopefully, the image makes it to GAR.