Bug 1856795 - Remove redundant member init r=emilio

Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .

https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html

Differential Revision: https://phabricator.services.mozilla.com/D190002

Author: sylvestre

accessible/atk/ApplicationAccessibleWrap.cpp

@@ -17,8 +17,7 @@ using namespace mozilla::a11y;
 
 // ApplicationAccessibleWrap
 
-ApplicationAccessibleWrap::ApplicationAccessibleWrap()
-    : ApplicationAccessible() {}
+ApplicationAccessibleWrap::ApplicationAccessibleWrap() {}
 
 ApplicationAccessibleWrap::~ApplicationAccessibleWrap() {
   AccessibleWrap::ShutdownAtkObject();

accessible/atk/RootAccessibleWrap.cpp

@@ -13,8 +13,7 @@
 
 using namespace mozilla::a11y;
 
-GtkWindowAccessible::GtkWindowAccessible(AtkObject* aAccessible)
-    : DummyAccessible() {
+GtkWindowAccessible::GtkWindowAccessible(AtkObject* aAccessible) {
   g_object_ref(aAccessible);
   mAtkObject = aAccessible;
 }

accessible/base/nsAccessibilityService.cpp

@@ -397,9 +397,7 @@ xpcAccessibleApplication* nsAccessibilityService::gXPCApplicationAccessible =
 uint32_t nsAccessibilityService::gConsumers = 0;
 
 nsAccessibilityService::nsAccessibilityService()
-    : DocManager(),
-      FocusManager(),
-      mHTMLMarkupMap(ArrayLength(sHTMLMarkupMapList)),
+    : mHTMLMarkupMap(ArrayLength(sHTMLMarkupMapList)),
       mMathMLMarkupMap(ArrayLength(sMathMLMarkupMapList)),
       mXULMarkupMap(ArrayLength(sXULMarkupMapList)) {}
 

accessible/generic/LocalAccessible.cpp

@@ -101,12 +101,10 @@ NS_IMPL_CYCLE_COLLECTING_ADDREF(LocalAccessible)
 NS_IMPL_CYCLE_COLLECTING_RELEASE_WITH_DESTROY(LocalAccessible, LastRelease())
 
 LocalAccessible::LocalAccessible(nsIContent* aContent, DocAccessible* aDoc)
-    : Accessible(),
-      mContent(aContent),
+    : mContent(aContent),
       mDoc(aDoc),
       mParent(nullptr),
       mIndexInParent(-1),
-      mBounds(),
       mFirstLineStart(-1),
       mStateFlags(0),
       mContextFlags(0),

accessible/ipc/RemoteAccessible.h

@@ -413,8 +413,7 @@ class RemoteAccessible : public Accessible, public HyperTextAccessibleBase {
   }
 
   explicit RemoteAccessible(DocAccessibleParent* aThisAsDoc)
-      : Accessible(),
-        mParent(kNoParent),
+      : mParent(kNoParent),
         mDoc(aThisAsDoc),
         mWrapper(0),
         mID(0),

devtools/shared/heapsnapshot/tests/gtest/DeserializedStackFrameUbiStackFrames.cpp

@@ -18,7 +18,7 @@ using testing::ReturnRef;
 
 // A mock DeserializedStackFrame for testing.
 struct MockDeserializedStackFrame : public DeserializedStackFrame {
-  MockDeserializedStackFrame() : DeserializedStackFrame() {}
+  MockDeserializedStackFrame() {}
 };
 
 DEF_TEST(DeserializedStackFrameUbiStackFrames, {

devtools/shared/heapsnapshot/tests/gtest/DevTools.h

@@ -99,7 +99,7 @@ class MOZ_STACK_CLASS FakeNode {
   JS::Zone* zone;
   size_t size;
 
-  explicit FakeNode() : edges(), compartment(nullptr), zone(nullptr), size(1) {}
+  explicit FakeNode() : compartment(nullptr), zone(nullptr), size(1) {}
 };
 
 namespace JS {

docshell/base/nsDocShellLoadState.cpp

@@ -222,7 +222,6 @@ nsDocShellLoadState::nsDocShellLoadState(nsIURI* aURI, uint64_t aLoadIdentifier)
       mOriginalFrameSrc(false),
       mIsFormSubmission(false),
       mLoadType(LOAD_NORMAL),
-      mTarget(),
       mSrcdocData(VoidString()),
       mLoadFlags(0),
       mInternalLoadFlags(0),

dom/animation/Animation.cpp

@@ -2051,7 +2051,7 @@ void Animation::UpdatePendingAnimationTracker(AnimationTimeline* aOldTimeline,
 class AsyncFinishNotification : public MicroTaskRunnable {
  public:
   explicit AsyncFinishNotification(Animation* aAnimation)
-      : MicroTaskRunnable(), mAnimation(aAnimation) {}
+      : mAnimation(aAnimation) {}
 
   virtual void Run(AutoSlowOperation& aAso) override {
     mAnimation->DoFinishNotificationImmediately(this);

dom/base/FragmentOrElement.cpp

@@ -559,8 +559,7 @@ size_t nsIContent::nsExtendedContentSlots::SizeOfExcludingThis(
   return 0;
 }
 
-FragmentOrElement::nsDOMSlots::nsDOMSlots()
-    : nsIContent::nsContentSlots(), mDataset(nullptr) {
+FragmentOrElement::nsDOMSlots::nsDOMSlots() : mDataset(nullptr) {
   MOZ_COUNT_CTOR(nsDOMSlots);
 }