Skip to content

Commit 2868a69

Browse files
author
epriestley
committedDec 17, 2015
Remove all setObjectURI() from ActionListViews
Summary: Ref T10004. After D14804, we get this behavior by default and no longer need to set it explicitly. (If some endpoint did eventually need to set it explicitly, it could just change what it passes to `setHref()`, but I believe we currently have no such endpoints and do not foresee ever having any.) Test Plan: - As a logged out user, clicked various links in Differential, Maniphest, Files, etc., always got redirected to a sensible place after login. - Grepped for `setObjectURI()`, `getObjectURI()` (there are a few remaining callsites, but to a different method with the same name in Doorkeeper). Reviewers: chad Reviewed By: chad Subscribers: hach-que Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14805
1 parent e869e7d commit 2868a69

File tree

49 files changed

+22
-111
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+22
-111
lines changed
 

‎src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

-1
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ private function buildActionView(PhabricatorCalendarEvent $event) {
152152
$is_attending = $event->getIsUserAttending($viewer->getPHID());
153153

154154
$actions = id(new PhabricatorActionListView())
155-
->setObjectURI($this->getApplicationURI('event/'.$id.'/'))
156155
->setUser($viewer)
157156
->setObject($event);
158157

‎src/applications/dashboard/controller/PhabricatorDashboardManageController.php

-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ private function buildActionView(PhabricatorDashboard $dashboard) {
9999
$id = $dashboard->getID();
100100

101101
$actions = id(new PhabricatorActionListView())
102-
->setObjectURI($this->getApplicationURI('view/'.$dashboard->getID().'/'))
103102
->setObject($dashboard)
104103
->setUser($viewer);
105104

0 commit comments

Comments
 (0)
Failed to load comments.