Skip to content

Commit 9001d5d

Browse files
pulsepriestley
puls
authored and
epriestley
committedNov 22, 2015
Add mask-icon for Safari pinned tab
Summary: Addresses T9814. Adds SVG files to Celerity maps. Adds a mask-icon.svg file that I made by pulling the existing favicon into Illustrator and running trace on it. This hardcodes the header color from the default theme, and doesn't pay attention to customizations of the header. Test Plan: I pinned the tab in Safari. Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: chad, Korvin Maniphest Tasks: T9814 Differential Revision: https://secure.phabricator.com/D14527
1 parent 62e129d commit 9001d5d

File tree

5 files changed

+51
-11
lines changed

5 files changed

+51
-11
lines changed
 

‎resources/celerity/map.php

+17-10
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,9 @@
108108
'rsrc/css/core/syntax.css' => '9fd11da8',
109109
'rsrc/css/core/z-index.css' => '57ddcaa2',
110110
'rsrc/css/diviner/diviner-shared.css' => 'aa3656aa',
111-
'rsrc/css/font/font-aleo.css' => 'b61d3062',
111+
'rsrc/css/font/font-aleo.css' => '8bdb2835',
112112
'rsrc/css/font/font-awesome.css' => 'd2fc4e8d',
113-
'rsrc/css/font/font-lato.css' => '5ab1a46a',
113+
'rsrc/css/font/font-lato.css' => 'c7ccd872',
114114
'rsrc/css/font/phui-font-icon-base.css' => 'ecbbb4c2',
115115
'rsrc/css/layout/phabricator-filetree-view.css' => 'fccf9f82',
116116
'rsrc/css/layout/phabricator-hovercard-view.css' => '1239cd52',
@@ -158,10 +158,12 @@
158158
'rsrc/css/sprite-projects.css' => 'e5ad842a',
159159
'rsrc/css/sprite-tokens.css' => '4f399012',
160160
'rsrc/externals/font/aleo/aleo-bold.eot' => 'd3d3bed7',
161+
'rsrc/externals/font/aleo/aleo-bold.svg' => '45899c8e',
161162
'rsrc/externals/font/aleo/aleo-bold.ttf' => '4b08bef0',
162163
'rsrc/externals/font/aleo/aleo-bold.woff' => '93b513a1',
163164
'rsrc/externals/font/aleo/aleo-bold.woff2' => '75fbf322',
164165
'rsrc/externals/font/aleo/aleo-regular.eot' => 'a4e29e2f',
166+
'rsrc/externals/font/aleo/aleo-regular.svg' => '42a86f7a',
165167
'rsrc/externals/font/aleo/aleo-regular.ttf' => '751e7479',
166168
'rsrc/externals/font/aleo/aleo-regular.woff' => 'c3744be9',
167169
'rsrc/externals/font/aleo/aleo-regular.woff2' => '851aa0ee',
@@ -170,18 +172,22 @@
170172
'rsrc/externals/font/fontawesome/fontawesome-webfont.woff' => '427fe363',
171173
'rsrc/externals/font/fontawesome/fontawesome-webfont.woff2' => 'a9897054',
172174
'rsrc/externals/font/lato/lato-bold.eot' => '99fbcf8c',
175+
'rsrc/externals/font/lato/lato-bold.svg' => '2aa83045',
173176
'rsrc/externals/font/lato/lato-bold.ttf' => '0a7141f7',
174177
'rsrc/externals/font/lato/lato-bold.woff' => 'f5db2061',
175178
'rsrc/externals/font/lato/lato-bold.woff2' => '37a94ecd',
176179
'rsrc/externals/font/lato/lato-bolditalic.eot' => 'b93389d0',
180+
'rsrc/externals/font/lato/lato-bolditalic.svg' => '5442e1ef',
177181
'rsrc/externals/font/lato/lato-bolditalic.ttf' => 'dad31252',
178182
'rsrc/externals/font/lato/lato-bolditalic.woff' => 'e53bcf47',
179183
'rsrc/externals/font/lato/lato-bolditalic.woff2' => 'd035007f',
180184
'rsrc/externals/font/lato/lato-italic.eot' => '6a903f5d',
185+
'rsrc/externals/font/lato/lato-italic.svg' => '0dc7cf2f',
181186
'rsrc/externals/font/lato/lato-italic.ttf' => '629f64f0',
182187
'rsrc/externals/font/lato/lato-italic.woff' => '678dc4bb',
183188
'rsrc/externals/font/lato/lato-italic.woff2' => '7c8dd650',
184189
'rsrc/externals/font/lato/lato-regular.eot' => '848dfb1e',
190+
'rsrc/externals/font/lato/lato-regular.svg' => 'cbd5fd6b',
185191
'rsrc/externals/font/lato/lato-regular.ttf' => 'e270165b',
186192
'rsrc/externals/font/lato/lato-regular.woff' => '13d39fe2',
187193
'rsrc/externals/font/lato/lato-regular.woff2' => '57a9f742',
@@ -255,6 +261,7 @@
255261
'rsrc/favicons/favicon-16x16.png' => 'ee2523ac',
256262
'rsrc/favicons/favicon-32x32.png' => 'b6a8150e',
257263
'rsrc/favicons/favicon-96x96.png' => '8f7ea177',
264+
'rsrc/favicons/mask-icon.svg' => '0460cb1f',
258265
'rsrc/image/BFCFDA.png' => 'd5ec91f4',
259266
'rsrc/image/actions/edit.png' => '2fc41442',
260267
'rsrc/image/avatar.png' => '3eb28cd9',
@@ -529,9 +536,9 @@
529536
'diffusion-readme-css' => '2106ea08',
530537
'diffusion-source-css' => '075ba788',
531538
'diviner-shared-css' => 'aa3656aa',
532-
'font-aleo' => 'b61d3062',
539+
'font-aleo' => '8bdb2835',
533540
'font-fontawesome' => 'd2fc4e8d',
534-
'font-lato' => '5ab1a46a',
541+
'font-lato' => 'c7ccd872',
535542
'global-drag-and-drop-css' => '697324ad',
536543
'harbormaster-css' => 'b0758ca5',
537544
'herald-css' => '826075fa',
@@ -1206,9 +1213,6 @@
12061213
'javelin-vector',
12071214
'javelin-dom',
12081215
),
1209-
'5ab1a46a' => array(
1210-
'phui-fontkit-css',
1211-
),
12121216
'5b2e3e2b' => array(
12131217
'javelin-stratcom',
12141218
'javelin-request',
@@ -1506,6 +1510,9 @@
15061510
'javelin-request',
15071511
'javelin-typeahead-source',
15081512
),
1513+
'8bdb2835' => array(
1514+
'phui-fontkit-css',
1515+
),
15091516
'8ce821c5' => array(
15101517
'phabricator-notification',
15111518
'javelin-stratcom',
@@ -1717,9 +1724,6 @@
17171724
'javelin-dom',
17181725
'javelin-util',
17191726
),
1720-
'b61d3062' => array(
1721-
'phui-fontkit-css',
1722-
),
17231727
'b6993408' => array(
17241728
'javelin-behavior',
17251729
'javelin-stratcom',
@@ -1775,6 +1779,9 @@
17751779
'phabricator-keyboard-shortcut',
17761780
'conpherence-thread-manager',
17771781
),
1782+
'c7ccd872' => array(
1783+
'phui-fontkit-css',
1784+
),
17781785
'c8e57404' => array(
17791786
'javelin-behavior',
17801787
'javelin-dom',

‎src/applications/celerity/controller/CelerityResourceController.php

+1
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ public static function getSupportedResourceTypes() {
125125
'css' => 'text/css; charset=utf-8',
126126
'js' => 'text/javascript; charset=utf-8',
127127
'png' => 'image/png',
128+
'svg' => 'image/svg+xml',
128129
'gif' => 'image/gif',
129130
'jpg' => 'image/jpeg',
130131
'swf' => 'application/x-shockwave-flash',

‎src/applications/celerity/resources/CelerityResourcesOnDisk.php

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ protected function getBinaryFileSuffixes() {
3333
'jpg',
3434
'gif',
3535
'swf',
36+
'svg',
3637
'woff',
3738
'woff2',
3839
'ttf',

‎src/view/page/PhabricatorBarePageView.php

+12-1
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,16 @@ protected function getHead() {
7575
'maximum-scale=1',
7676
));
7777
}
78+
79+
$mask_icon = phutil_tag(
80+
'link',
81+
array(
82+
'rel' => 'mask-icon',
83+
'color' => '#3D4B67',
84+
'href' => celerity_get_resource_uri(
85+
'/rsrc/favicons/mask-icon.svg'),
86+
));
87+
7888
$icon_tag_76 = phutil_tag(
7989
'link',
8090
array(
@@ -130,8 +140,9 @@ protected function getHead() {
130140

131141
$developer = PhabricatorEnv::getEnvConfig('phabricator.developer-mode');
132142
return hsprintf(
133-
'%s%s%s%s%s%s%s%s',
143+
'%s%s%s%s%s%s%s%s%s',
134144
$viewport_tag,
145+
$mask_icon,
135146
$icon_tag_76,
136147
$icon_tag_120,
137148
$icon_tag_152,

‎webroot/rsrc/favicons/mask-icon.svg

+20
Loading

0 commit comments

Comments
 (0)
Failed to load comments.