Skip to content

Commit 2ebdf2e

Browse files
author
Chad Little
committedMar 8, 2017
Remove server side limit on policy control names
Summary: Fixes T12367. CSS here already truncates (or should have been) and is generally more effective. Remove the unneeded server side truncation. Any other UI place these render? Test Plan: Set Policy to a group name of "Stanford University: Alumni Association and Friends" and see better truncation. Reviewers: epriestley, eliaspro Reviewed By: epriestley, eliaspro Subscribers: eliaspro, Korvin Maniphest Tasks: T12367 Differential Revision: https://secure.phabricator.com/D17479
1 parent 683b022 commit 2ebdf2e

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed
 

‎resources/celerity/map.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
'names' => array(
1010
'conpherence.pkg.css' => '6875302f',
1111
'conpherence.pkg.js' => '6249a1cf',
12-
'core.pkg.css' => 'bb303011',
12+
'core.pkg.css' => '7e10ec60',
1313
'core.pkg.js' => '1fa7c0c5',
1414
'darkconsole.pkg.js' => 'e7393ebb',
1515
'differential.pkg.css' => '90b30783',
@@ -128,7 +128,7 @@
128128
'rsrc/css/phui/object-item/phui-oi-flush-ui.css' => '9d9685d6',
129129
'rsrc/css/phui/object-item/phui-oi-list-view.css' => '5c383524',
130130
'rsrc/css/phui/object-item/phui-oi-simple-ui.css' => 'a8beebea',
131-
'rsrc/css/phui/phui-action-list.css' => 'f980c059',
131+
'rsrc/css/phui/phui-action-list.css' => '29bb1c5e',
132132
'rsrc/css/phui/phui-action-panel.css' => '91c7b835',
133133
'rsrc/css/phui/phui-badge.css' => '22c0cf4f',
134134
'rsrc/css/phui/phui-basic-nav-view.css' => 'a0705f53',
@@ -780,7 +780,7 @@
780780
'path-typeahead' => 'f7fc67ec',
781781
'people-picture-menu-item-css' => 'a06f7f34',
782782
'people-profile-css' => '4df76faf',
783-
'phabricator-action-list-view-css' => 'f980c059',
783+
'phabricator-action-list-view-css' => '29bb1c5e',
784784
'phabricator-busy' => '59a7976a',
785785
'phabricator-chatlog-css' => 'd295b020',
786786
'phabricator-content-source-view-css' => '4b8b05d4',

‎src/view/form/control/AphrontFormPolicyControl.php

+1-5
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,8 @@ protected function getOptions() {
153153
}
154154
}
155155

156-
$policy_short_name = id(new PhutilUTF8StringTruncator())
157-
->setMaximumGlyphs(28)
158-
->truncateString($policy->getName());
159-
160156
$options[$policy->getType()][$policy->getPHID()] = array(
161-
'name' => $policy_short_name,
157+
'name' => $policy->getName(),
162158
'full' => $policy->getName(),
163159
'icon' => $policy->getIcon(),
164160
'sort' => phutil_utf8_strtolower($policy->getName()),

‎webroot/rsrc/css/phui/phui-action-list.css

+1
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
color: {$darkbluetext};
7070
text-overflow: ellipsis;
7171
overflow: hidden;
72+
white-space: nowrap;
7273
}
7374

7475
.action-has-icon button.phabricator-action-view-item,

0 commit comments

Comments
 (0)
Failed to load comments.