Add a sort order to the favorites menu

Summary: These were once ordered, but I think we switched to being defined in the Engine and never implemented the sorts there. This adds sort ordering to Tasks, Projects, and Repositories.

Test Plan: Review Favorites Menu in local install, see order is now set per the engine. Click Edit Favorites, and re-order. See order sticks.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17490

Author: Chad Little

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

@@ -24,6 +24,10 @@ public function isDefaultQuickCreateEngine() {
     return true;
   }
 
+  public function getQuickCreateOrderVector() {
+    return id(new PhutilSortVector())->addInt(300);
+  }
+
   public function getEngineName() {
     return pht('Repositories');
   }

src/applications/maniphest/editor/ManiphestEditEngine.php

@@ -25,6 +25,10 @@ public function isDefaultQuickCreateEngine() {
     return true;
   }
 
+  public function getQuickCreateOrderVector() {
+    return id(new PhutilSortVector())->addInt(100);
+  }
+
   protected function newEditableObject() {
     return ManiphestTask::initializeNewTask($this->getViewer());
   }

src/applications/project/engine/PhabricatorProjectEditEngine.php

@@ -30,6 +30,10 @@ public function isDefaultQuickCreateEngine() {
     return true;
   }
 
+  public function getQuickCreateOrderVector() {
+    return id(new PhutilSortVector())->addInt(200);
+  }
+
   public function getEngineName() {
     return pht('Projects');
   }