Skip to content

Commit 4c7d464

Browse files
author
Chad Little
committedMar 9, 2017
Fix firefox submenu arrows on action lists
Summary: Fixes T12370. Moves this to be absolutely positions so the float doesn't mess up text-overflow layouts. Test Plan: Chrome, Safari, Firefox, mobile and desktop layouts of Maniphest submenus. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T12370 Differential Revision: https://secure.phabricator.com/D17484
1 parent 2fed5b6 commit 4c7d464

File tree

3 files changed

+33
-31
lines changed

3 files changed

+33
-31
lines changed
 

‎resources/celerity/map.php

+5-5
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
'names' => array(
1010
'conpherence.pkg.css' => '6875302f',
1111
'conpherence.pkg.js' => '6249a1cf',
12-
'core.pkg.css' => 'db710bcc',
12+
'core.pkg.css' => '49a02d1f',
1313
'core.pkg.js' => '1fa7c0c5',
1414
'darkconsole.pkg.js' => 'e7393ebb',
1515
'differential.pkg.css' => '90b30783',
@@ -128,13 +128,13 @@
128128
'rsrc/css/phui/object-item/phui-oi-flush-ui.css' => '9d9685d6',
129129
'rsrc/css/phui/object-item/phui-oi-list-view.css' => '5c383524',
130130
'rsrc/css/phui/object-item/phui-oi-simple-ui.css' => 'a8beebea',
131-
'rsrc/css/phui/phui-action-list.css' => '29bb1c5e',
131+
'rsrc/css/phui/phui-action-list.css' => 'c01858f4',
132132
'rsrc/css/phui/phui-action-panel.css' => '91c7b835',
133133
'rsrc/css/phui/phui-badge.css' => '22c0cf4f',
134134
'rsrc/css/phui/phui-basic-nav-view.css' => 'a0705f53',
135135
'rsrc/css/phui/phui-big-info-view.css' => 'bd903741',
136136
'rsrc/css/phui/phui-box.css' => '269cbc99',
137-
'rsrc/css/phui/phui-button.css' => 'd30999e4',
137+
'rsrc/css/phui/phui-button.css' => 'c55204db',
138138
'rsrc/css/phui/phui-chart.css' => '6bf6f78e',
139139
'rsrc/css/phui/phui-cms.css' => '504b4b23',
140140
'rsrc/css/phui/phui-comment-form.css' => '48fbd65d',
@@ -780,7 +780,7 @@
780780
'path-typeahead' => 'f7fc67ec',
781781
'people-picture-menu-item-css' => 'a06f7f34',
782782
'people-profile-css' => '4df76faf',
783-
'phabricator-action-list-view-css' => '29bb1c5e',
783+
'phabricator-action-list-view-css' => 'c01858f4',
784784
'phabricator-busy' => '59a7976a',
785785
'phabricator-chatlog-css' => 'd295b020',
786786
'phabricator-content-source-view-css' => '4b8b05d4',
@@ -841,7 +841,7 @@
841841
'phui-basic-nav-view-css' => 'a0705f53',
842842
'phui-big-info-view-css' => 'bd903741',
843843
'phui-box-css' => '269cbc99',
844-
'phui-button-css' => 'd30999e4',
844+
'phui-button-css' => 'c55204db',
845845
'phui-calendar-css' => '477acfaa',
846846
'phui-calendar-day-css' => '572b1893',
847847
'phui-calendar-list-css' => '576be600',

‎webroot/rsrc/css/phui/phui-action-list.css

+28
Original file line numberDiff line numberDiff line change
@@ -165,3 +165,31 @@
165165
margin-top: 8px;
166166
border-top: 1px solid {$thinblueborder};
167167
}
168+
169+
/******* Sub Menu *************************************************************/
170+
171+
.phabricator-action-view-submenu .caret-right {
172+
position: absolute;
173+
top: 8px;
174+
right: 8px;
175+
border-left-color: {$alphablue};
176+
}
177+
178+
.phabricator-action-view-submenu .caret {
179+
position: absolute;
180+
top: 10px;
181+
right: 8px;
182+
border-top: 7px solid {$lightgreytext};
183+
}
184+
185+
.phabricator-action-list-view .phabricator-action-view-submenu.phui-submenu-open
186+
.phabricator-action-view-item {
187+
background-color: rgba({$alphablue}, 0.07);
188+
color: {$sky};
189+
border-radius: 3px;
190+
}
191+
192+
.phabricator-action-list-view .phabricator-action-view-submenu.phui-submenu-open
193+
.phabricator-action-view-item .phui-icon-view {
194+
color: {$sky};
195+
}

‎webroot/rsrc/css/phui/phui-button.css

-26
Original file line numberDiff line numberDiff line change
@@ -290,32 +290,6 @@ a.policy-control .phui-button-text {
290290
border-top-color: #000;
291291
}
292292

293-
.phabricator-action-view-submenu .caret-right {
294-
float: right;
295-
margin-top: 4px;
296-
margin-right: 6px;
297-
border-left-color: {$alphablue};
298-
}
299-
300-
.phabricator-action-view-submenu .caret {
301-
float: right;
302-
margin-top: 5px;
303-
margin-right: 4px;
304-
border-top: 7px solid {$lightgreytext};
305-
}
306-
307-
.phabricator-action-list-view .phabricator-action-view-submenu.phui-submenu-open
308-
.phabricator-action-view-item {
309-
background-color: rgba({$alphablue}, 0.07);
310-
color: {$sky};
311-
border-radius: 3px;
312-
}
313-
314-
.phabricator-action-list-view .phabricator-action-view-submenu.phui-submenu-open
315-
.phabricator-action-view-item .phui-icon-view {
316-
color: {$sky};
317-
}
318-
319293
/* Icons */
320294
.button.has-icon {
321295
position: relative;

0 commit comments

Comments
 (0)
Failed to load comments.