Remove dashboard footer

Summary: Doesn't seem popular, will rethink dashboard editing again in the future at some point.

Test Plan: Review a dashboard, edit, install.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17450

Author: Chad Little

resources/celerity/map.php

@@ -9,7 +9,7 @@
   'names' => array(
     'conpherence.pkg.css' => '6875302f',
     'conpherence.pkg.js' => '6249a1cf',
-    'core.pkg.css' => 'c0340df0',
+    'core.pkg.css' => '52a77c4d',
     'core.pkg.js' => '1fa7c0c5',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => '90b30783',
@@ -55,7 +55,7 @@
     'rsrc/css/application/contentsource/content-source-view.css' => '4b8b05d4',
     'rsrc/css/application/countdown/timer.css' => '16c52f5c',
     'rsrc/css/application/daemon/bulk-job.css' => 'df9c1d4a',
-    'rsrc/css/application/dashboard/dashboard.css' => '0921c307',
+    'rsrc/css/application/dashboard/dashboard.css' => 'fe5b1869',
     'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a',
     'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
     'rsrc/css/application/differential/changeset-view.css' => '41af6d25',
@@ -786,7 +786,7 @@
     'phabricator-content-source-view-css' => '4b8b05d4',
     'phabricator-core-css' => '9f4cb463',
     'phabricator-countdown-css' => '16c52f5c',
-    'phabricator-dashboard-css' => '0921c307',
+    'phabricator-dashboard-css' => 'fe5b1869',
     'phabricator-drag-and-drop-file-upload' => '58dea2fa',
     'phabricator-draggable-list' => 'bea6e7f4',
     'phabricator-fatal-config-template-css' => '8f18fa41',

src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php

@@ -81,43 +81,17 @@ public function renderDashboard() {
     }
 
     if ($this->arrangeMode) {
-      $footer = null;
       Javelin::initBehavior(
         'dashboard-move-panels',
         array(
           'dashboardID' => $dashboard_id,
           'moveURI' => '/dashboard/movepanel/'.$dashboard->getID().'/',
         ));
-    } else {
-      $name = $dashboard->getName();
-      $icon = id(new PHUIIconView())
-        ->setIcon($dashboard->getIcon())
-        ->addClass('msr');
-      $footer_left = phutil_tag(
-        'a',
-        array(
-          'class' => 'dashboard-footer-name',
-          'href' => '/dashboard/view/'.$dashboard->getID().'/',
-        ),
-        array(
-          $icon,
-          $name,
-        ));
-
-      $footer = phutil_tag(
-        'div',
-        array(
-          'class' => 'dashboard-footer-view',
-        ),
-        array(
-          $footer_left,
-        ));
     }
 
     $view = id(new PHUIBoxView())
       ->addClass('dashboard-view')
-      ->appendChild($result)
-      ->appendChild($footer);
+      ->appendChild($result);
 
     return $view;
   }

webroot/rsrc/css/application/dashboard/dashboard.css

@@ -106,17 +106,3 @@
 .drag-frame .phui-object-box .phui-object-box {
   box-shadow: none;
 }
-
-/*** Footer *******************************************************************/
-
-.dashboard-footer-view {
-  background-color: {$page.sidenav};
-  padding: 8px 16px;
-  border-radius: 3px;
-}
-
-.dashboard-footer-name {
-  color: {$darkbluetext};
-  font-weight: bold;
-  -webkit-font-smoothing: antialiased;
-}