Share rendering code for embedded votes and vote detail

Summary:
We have two separate pieces of rendering code and both are pretty ugly. Move them toward being more reasonable.

This could no doubt be improved:

  - Getting a text style which was readable on both the dark and light bars was hard, maybe we should change the colors or maybe I am just bad.
  - Could probably benefit from actual competent design in general.
  - JS magic is temporarily ineffective, I'll restore that in the future.
  - Embed style is a little funky (margin/centering).
  - Could use a little cleanup.

Test Plan:
{F50226}
{F50227}
{F50228}

Reviewers: chad, btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D6465

Author: epriestley

src/__celerity_resource_map__.php

@@ -3475,7 +3475,7 @@
   ),
   'phabricator-slowvote-css' =>
   array(
-    'uri' => '/res/d1c2e05a/rsrc/css/application/slowvote/slowvote.css',
+    'uri' => '/res/11373549/rsrc/css/application/slowvote/slowvote.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3702,7 +3702,7 @@
   ),
   'phabricator-zindex-css' =>
   array(
-    'uri' => '/res/99a9447b/rsrc/css/core/z-index.css',
+    'uri' => '/res/a50437bf/rsrc/css/core/z-index.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -4149,7 +4149,7 @@
 ), array(
   'packages' =>
   array(
-    'c01cebae' =>
+    'f32a863a' =>
     array(
       'name' => 'core.pkg.css',
       'symbols' =>
@@ -4197,7 +4197,7 @@
         40 => 'phabricator-property-list-view-css',
         41 => 'phabricator-tag-view-css',
       ),
-      'uri' => '/res/pkg/c01cebae/core.pkg.css',
+      'uri' => '/res/pkg/f32a863a/core.pkg.css',
       'type' => 'css',
     ),
     '75ccea43' =>
@@ -4391,16 +4391,16 @@
   'reverse' =>
   array(
     'aphront-attached-file-view-css' => 'adc3c36d',
-    'aphront-dialog-view-css' => 'c01cebae',
-    'aphront-error-view-css' => 'c01cebae',
-    'aphront-form-view-css' => 'c01cebae',
-    'aphront-list-filter-view-css' => 'c01cebae',
-    'aphront-pager-view-css' => 'c01cebae',
-    'aphront-panel-view-css' => 'c01cebae',
-    'aphront-table-view-css' => 'c01cebae',
-    'aphront-tokenizer-control-css' => 'c01cebae',
-    'aphront-tooltip-css' => 'c01cebae',
-    'aphront-typeahead-control-css' => 'c01cebae',
+    'aphront-dialog-view-css' => 'f32a863a',
+    'aphront-error-view-css' => 'f32a863a',
+    'aphront-form-view-css' => 'f32a863a',
+    'aphront-list-filter-view-css' => 'f32a863a',
+    'aphront-pager-view-css' => 'f32a863a',
+    'aphront-panel-view-css' => 'f32a863a',
+    'aphront-table-view-css' => 'f32a863a',
+    'aphront-tokenizer-control-css' => 'f32a863a',
+    'aphront-tooltip-css' => 'f32a863a',
+    'aphront-typeahead-control-css' => 'f32a863a',
     'differential-changeset-view-css' => 'dd27a69b',
     'differential-core-view-css' => 'dd27a69b',
     'differential-inline-comment-editor' => '504ca7d2',
@@ -4414,7 +4414,7 @@
     'differential-table-of-contents-css' => 'dd27a69b',
     'diffusion-commit-view-css' => 'c8ce2d88',
     'diffusion-icons-css' => 'c8ce2d88',
-    'global-drag-and-drop-css' => 'c01cebae',
+    'global-drag-and-drop-css' => 'f32a863a',
     'inline-comment-summary-css' => 'dd27a69b',
     'javelin-aphlict' => '75ccea43',
     'javelin-behavior' => 'a9f14d76',
@@ -4488,55 +4488,55 @@
     'javelin-util' => 'a9f14d76',
     'javelin-vector' => 'a9f14d76',
     'javelin-workflow' => 'a9f14d76',
-    'lightbox-attachment-css' => 'c01cebae',
+    'lightbox-attachment-css' => 'f32a863a',
     'maniphest-task-summary-css' => 'adc3c36d',
     'maniphest-transaction-detail-css' => 'adc3c36d',
-    'phabricator-action-list-view-css' => 'c01cebae',
-    'phabricator-application-launch-view-css' => 'c01cebae',
+    'phabricator-action-list-view-css' => 'f32a863a',
+    'phabricator-application-launch-view-css' => 'f32a863a',
     'phabricator-busy' => '75ccea43',
     'phabricator-content-source-view-css' => 'dd27a69b',
-    'phabricator-core-css' => 'c01cebae',
-    'phabricator-crumbs-view-css' => 'c01cebae',
+    'phabricator-core-css' => 'f32a863a',
+    'phabricator-crumbs-view-css' => 'f32a863a',
     'phabricator-drag-and-drop-file-upload' => '504ca7d2',
     'phabricator-dropdown-menu' => '75ccea43',
     'phabricator-file-upload' => '75ccea43',
-    'phabricator-filetree-view-css' => 'c01cebae',
-    'phabricator-flag-css' => 'c01cebae',
-    'phabricator-form-view-css' => 'c01cebae',
-    'phabricator-header-view-css' => 'c01cebae',
+    'phabricator-filetree-view-css' => 'f32a863a',
+    'phabricator-flag-css' => 'f32a863a',
+    'phabricator-form-view-css' => 'f32a863a',
+    'phabricator-header-view-css' => 'f32a863a',
     'phabricator-hovercard' => '75ccea43',
-    'phabricator-jump-nav' => 'c01cebae',
+    'phabricator-jump-nav' => 'f32a863a',
     'phabricator-keyboard-shortcut' => '75ccea43',
     'phabricator-keyboard-shortcut-manager' => '75ccea43',
-    'phabricator-main-menu-view' => 'c01cebae',
+    'phabricator-main-menu-view' => 'f32a863a',
     'phabricator-menu-item' => '75ccea43',
-    'phabricator-nav-view-css' => 'c01cebae',
+    'phabricator-nav-view-css' => 'f32a863a',
     'phabricator-notification' => '75ccea43',
-    'phabricator-notification-css' => 'c01cebae',
-    'phabricator-notification-menu-css' => 'c01cebae',
-    'phabricator-object-item-list-view-css' => 'c01cebae',
+    'phabricator-notification-css' => 'f32a863a',
+    'phabricator-notification-menu-css' => 'f32a863a',
+    'phabricator-object-item-list-view-css' => 'f32a863a',
     'phabricator-object-selector-css' => 'dd27a69b',
     'phabricator-phtize' => '75ccea43',
     'phabricator-prefab' => '75ccea43',
     'phabricator-project-tag-css' => 'adc3c36d',
-    'phabricator-property-list-view-css' => 'c01cebae',
-    'phabricator-remarkup-css' => 'c01cebae',
+    'phabricator-property-list-view-css' => 'f32a863a',
+    'phabricator-remarkup-css' => 'f32a863a',
     'phabricator-shaped-request' => '504ca7d2',
-    'phabricator-side-menu-view-css' => 'c01cebae',
-    'phabricator-standard-page-view' => 'c01cebae',
-    'phabricator-tag-view-css' => 'c01cebae',
+    'phabricator-side-menu-view-css' => 'f32a863a',
+    'phabricator-standard-page-view' => 'f32a863a',
+    'phabricator-tag-view-css' => 'f32a863a',
     'phabricator-textareautils' => '75ccea43',
     'phabricator-tooltip' => '75ccea43',
-    'phabricator-transaction-view-css' => 'c01cebae',
-    'phabricator-zindex-css' => 'c01cebae',
-    'phui-button-css' => 'c01cebae',
-    'phui-form-css' => 'c01cebae',
-    'phui-icon-view-css' => 'c01cebae',
-    'phui-spacing-css' => 'c01cebae',
-    'sprite-apps-large-css' => 'c01cebae',
-    'sprite-gradient-css' => 'c01cebae',
-    'sprite-icons-css' => 'c01cebae',
-    'sprite-menu-css' => 'c01cebae',
-    'syntax-highlighting-css' => 'c01cebae',
+    'phabricator-transaction-view-css' => 'f32a863a',
+    'phabricator-zindex-css' => 'f32a863a',
+    'phui-button-css' => 'f32a863a',
+    'phui-form-css' => 'f32a863a',
+    'phui-icon-view-css' => 'f32a863a',
+    'phui-spacing-css' => 'f32a863a',
+    'sprite-apps-large-css' => 'f32a863a',
+    'sprite-gradient-css' => 'f32a863a',
+    'sprite-icons-css' => 'f32a863a',
+    'sprite-menu-css' => 'f32a863a',
+    'syntax-highlighting-css' => 'f32a863a',
   ),
 ));

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

@@ -51,7 +51,7 @@ public function processRequest() {
     if ($request->isFormPost()) {
       $v_question = $request->getStr('question');
       $v_description = $request->getStr('description');
-      $v_responses = $request->getInt('responses');
+      $v_responses = (int)$request->getInt('responses');
       $v_shuffle = (int)$request->getBool('shuffle');
 
       if ($is_new) {