Skip to content

Commit dd7087f

Browse files
author
vrana
committedApr 17, 2012
Don't send empty testplan in e-mail
Summary: Allowed after D2193. Test Plan: Disable `differential.require-test-plan-field`, create diff without test plan. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2252
1 parent fbfccf5 commit dd7087f

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed
 

‎src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php

+5-3
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,11 @@ protected function renderReviewRequestBody() {
5656
$body[] = null;
5757
}
5858

59-
$body[] = 'TEST PLAN';
60-
$body[] = $this->formatText($revision->getTestPlan());
61-
$body[] = null;
59+
if ($revision->getTestPlan() != '') {
60+
$body[] = 'TEST PLAN';
61+
$body[] = $this->formatText($revision->getTestPlan());
62+
$body[] = null;
63+
}
6264
} else {
6365
if (strlen($this->getComments())) {
6466
$body[] = $this->formatText($this->getComments());

0 commit comments

Comments
 (0)
Failed to load comments.