Skip to content

Commit 2f66849

Browse files
joshuaspenceepriestley
authored and
epriestley
committedMay 29, 2014
Don't attempt to discover parents commits for untracked branchs.
Summary: Fixes T5195. Currently, the `./bin/repository parents` workflow doesn't respect tracked branches and will attempt to build parents caches for all branches. Test Plan: For at least one of our repositories, this patch fixes the `Unknown commit` exception. Unfortunately, it doesn't seem to completely solve this problem though, but I suspect that this is due to commits that were overwritten with a `git push --force` or similar. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5195 Differential Revision: https://secure.phabricator.com/D9322
1 parent 3929309 commit 2f66849

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed
 

‎src/applications/repository/management/PhabricatorRepositoryManagementParentsWorkflow.php

+4
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,10 @@ private function rebuildRepository(PhabricatorRepository $repo) {
5858

5959
$graph = array();
6060
foreach ($refs as $ref) {
61+
if (!$repo->shouldTrackBranch($ref->getRefName())) {
62+
continue;
63+
}
64+
6165
$console->writeOut(
6266
"%s\n",
6367
pht('Rebuilding branch "%s"...', $ref->getRefName()));

0 commit comments

Comments
 (0)
Failed to load comments.