Skip to content

Commit 323c529

Browse files
joshuaspenceepriestley
authored and
epriestley
committedMay 30, 2014
Allow the notifications from Aphlict debug messages to expire.
Summary: Currently, debugging (log) messages from the Aphlict client trigger a visible notification in the web UI (when `notification.debug` is enabled). After D9327, the log messages can be quite verbose and seem to "block" legitimate notifications because they are not automatically dismissed. Test Plan: Enabled `notification.debug` and observed that the debugging notifications expired and closed after a few seconds. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9339
1 parent 802463c commit 323c529

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed
 

‎resources/celerity/map.php

+16-16
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
'names' =>
99
array(
1010
'core.pkg.css' => '8ecc2a14',
11-
'core.pkg.js' => '7db41c19',
11+
'core.pkg.js' => '639b2433',
1212
'darkconsole.pkg.js' => 'ca8671ce',
1313
'differential.pkg.css' => 'fbf57382',
1414
'differential.pkg.js' => 'f4c86691',
@@ -344,7 +344,7 @@
344344
'rsrc/image/texture/table_header_tall.png' => 'd56b434f',
345345
'rsrc/js/application/aphlict/Aphlict.js' => '493665ee',
346346
'rsrc/js/application/aphlict/behavior-aphlict-dropdown.js' => '2a2dba85',
347-
'rsrc/js/application/aphlict/behavior-aphlict-listen.js' => '0a6c2de6',
347+
'rsrc/js/application/aphlict/behavior-aphlict-listen.js' => '9aa97ab6',
348348
'rsrc/js/application/auth/behavior-persona-login.js' => '9414ff18',
349349
'rsrc/js/application/config/behavior-reorder-fields.js' => '938aed89',
350350
'rsrc/js/application/conpherence/behavior-menu.js' => '7ee23816',
@@ -482,7 +482,7 @@
482482
'rsrc/js/phuix/PHUIXActionListView.js' => 'b5c256b8',
483483
'rsrc/js/phuix/PHUIXActionView.js' => '6e8cefa4',
484484
'rsrc/js/phuix/PHUIXDropdownMenu.js' => 'bd4c8dca',
485-
'rsrc/swf/aphlict.swf' => '731d14a6',
485+
'rsrc/swf/aphlict.swf' => 'f22c1e40',
486486
),
487487
'symbols' =>
488488
array(
@@ -532,7 +532,7 @@
532532
'javelin-aphlict' => '493665ee',
533533
'javelin-behavior' => '8a3ed18b',
534534
'javelin-behavior-aphlict-dropdown' => '2a2dba85',
535-
'javelin-behavior-aphlict-listen' => '0a6c2de6',
535+
'javelin-behavior-aphlict-listen' => '9aa97ab6',
536536
'javelin-behavior-aphront-basic-tokenizer' => 'b3a4b884',
537537
'javelin-behavior-aphront-crop' => 'b98fc918',
538538
'javelin-behavior-aphront-drag-and-drop-textarea' => '4a11ea9c',
@@ -891,18 +891,6 @@
891891
3 => 'javelin-dom',
892892
4 => 'javelin-router',
893893
),
894-
'0a6c2de6' =>
895-
array(
896-
0 => 'javelin-behavior',
897-
1 => 'javelin-aphlict',
898-
2 => 'javelin-stratcom',
899-
3 => 'javelin-request',
900-
4 => 'javelin-uri',
901-
5 => 'javelin-dom',
902-
6 => 'javelin-json',
903-
7 => 'javelin-router',
904-
8 => 'phabricator-notification',
905-
),
906894
'0c33c1a0' =>
907895
array(
908896
0 => 'javelin-view',
@@ -1539,6 +1527,18 @@
15391527
3 => 'javelin-dom',
15401528
4 => 'phabricator-draggable-list',
15411529
),
1530+
'9aa97ab6' =>
1531+
array(
1532+
0 => 'javelin-behavior',
1533+
1 => 'javelin-aphlict',
1534+
2 => 'javelin-stratcom',
1535+
3 => 'javelin-request',
1536+
4 => 'javelin-uri',
1537+
5 => 'javelin-dom',
1538+
6 => 'javelin-json',
1539+
7 => 'javelin-router',
1540+
8 => 'phabricator-notification',
1541+
),
15421542
'9b9197be' =>
15431543
array(
15441544
0 => 'javelin-behavior',

‎webroot/rsrc/js/application/aphlict/behavior-aphlict-listen.js

-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ JX.behavior('aphlict-listen', function(config) {
4141
new JX.Notification()
4242
.setContent('(Aphlict) [' + type + '] ' + details)
4343
.alterClassName('jx-notification-debug', true)
44-
.setDuration(0)
4544
.show();
4645
}
4746
}

0 commit comments

Comments
 (0)
Failed to load comments.