phacility · May 7, 2014 · May 8, 2014 · May 8, 2014 · May 8, 2014 · May 8, 2014
Showing with 37 additions and 11 deletions.

+10 −10 resources/celerity/map.php

+9 −0 src/applications/doorkeeper/worker/DoorkeeperFeedWorkerJIRA.php

+4 −1 src/view/phui/PHUITimelineView.php

+14 −0 webroot/rsrc/js/application/differential/behavior-keyboard-nav.js
diff --git a/resources/celerity/map.php b/resources/celerity/map.php
@@ -11,7 +11,7 @@
     'core.pkg.js' => 'b2ed04a2',
     'darkconsole.pkg.js' => 'ca8671ce',
     'differential.pkg.css' => '4b8686e3',
-    'differential.pkg.js' => '05ad02d3',
+    'differential.pkg.js' => '1b63ecad',
     'diffusion.pkg.css' => '3783278d',
     'diffusion.pkg.js' => '5b4010f4',
     'javelin.pkg.js' => 'dbef0389',
@@ -366,7 +366,7 @@
     'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1',
     'rsrc/js/application/differential/behavior-dropdown-menus.js' => '7f93ef26',
     'rsrc/js/application/differential/behavior-edit-inline-comments.js' => '00861799',
-    'rsrc/js/application/differential/behavior-keyboard-nav.js' => '173ce7e7',
+    'rsrc/js/application/differential/behavior-keyboard-nav.js' => 'c0ce0f6c',
     'rsrc/js/application/differential/behavior-populate.js' => 'dfdf9f34',
     'rsrc/js/application/differential/behavior-show-all-comments.js' => '7c273581',
     'rsrc/js/application/differential/behavior-show-field-details.js' => '441f2137',
@@ -559,7 +559,7 @@
     'javelin-behavior-differential-dropdown-menus' => '7f93ef26',
     'javelin-behavior-differential-edit-inline-comments' => '00861799',
     'javelin-behavior-differential-feedback-preview' => '127f2018',
-    'javelin-behavior-differential-keyboard-navigation' => '173ce7e7',
+    'javelin-behavior-differential-keyboard-navigation' => 'c0ce0f6c',
     'javelin-behavior-differential-populate' => 'dfdf9f34',
     'javelin-behavior-differential-show-field-details' => '441f2137',
     'javelin-behavior-differential-show-more' => 'dd7e8ef5',
@@ -964,13 +964,6 @@
       1 => 'javelin-dom',
       2 => 'phortune-credit-card-form',
     ),
-    '173ce7e7' =>
-    array(
-      0 => 'javelin-behavior',
-      1 => 'javelin-dom',
-      2 => 'javelin-stratcom',
-      3 => 'phabricator-keyboard-shortcut',
-    ),
     '189e4fe3' =>
     array(
       0 => 'javelin-install',
@@ -1722,6 +1715,13 @@
       5 => 'javelin-workflow',
       6 => 'javelin-vector',
     ),
+    'c0ce0f6c' =>
+    array(
+      0 => 'javelin-behavior',
+      1 => 'javelin-dom',
+      2 => 'javelin-stratcom',
+      3 => 'phabricator-keyboard-shortcut',
+    ),
     'c293f7b9' =>
     array(
       0 => 'javelin-install',

diff --git a/src/applications/doorkeeper/worker/DoorkeeperFeedWorkerJIRA.php b/src/applications/doorkeeper/worker/DoorkeeperFeedWorkerJIRA.php
@@ -55,6 +55,15 @@ protected function publishFeedStory() {
     }
 
     $story_text = $this->renderStoryText();
+    if (!strstr($story_text, "created")
+        && !strstr($story_text, "updated D")  // if someone attaches a JIRA issue
+        && !strstr($story_text, "reclaimed")
+        && !strstr($story_text, "abandoned")
+        && !strstr($story_text, "closed")
+        && !strstr($story_text, "commandeered")) {
+      $this->log("Skipping an uninteresting update\n");
+      return;
+    }
 
     $xobjs = mgroup($xobjs, 'getApplicationDomain');
     foreach ($xobjs as $domain => $xobj_list) {

diff --git a/src/view/phui/PHUITimelineView.php b/src/view/phui/PHUITimelineView.php
@@ -92,7 +92,10 @@ public function render() {
     }
 
     if ($events) {
-      $events = array($spacer, $events, $spacer);
+      $nav_anchor = id(new PhabricatorAnchorView())
+        ->setAnchorName('timeline')
+        ->setNavigationMarker(true);
+      $events = array($nav_anchor, $spacer, $events, $spacer);
     } else {
       $events = array($spacer);
     }

diff --git a/webroot/rsrc/js/application/differential/behavior-keyboard-nav.js b/webroot/rsrc/js/application/differential/behavior-keyboard-nav.js
@@ -227,6 +227,20 @@ JX.behavior('differential-keyboard-navigation', function(config) {
     })
     .register();
 
+  new JX.KeyboardShortcut('d', 'Jump to the discussion.')
+    .setHandler(function(manager) {
+      var discussion = JX.$('timeline');
+      manager.scrollTo(discussion);
+    })
+    .register();
+
+  new JX.KeyboardShortcut('c', 'Jump to the comments box.')
+    .setHandler(function(manager) {
+      var comments_box = JX.$('comment');
+      manager.scrollTo(comments_box);
+    })
+    .register();
+
   new JX.KeyboardShortcut(
     'h',
     'Collapse or expand the file display (after jump).')