Add validation to allowed directories on config load #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphralG
reviewed
Jul 1, 2025
| // isAllowedDir checks if the given path is in the list of allowed directories. | ||
| // It returns true if the path is allowed, false otherwise. | ||
| // If the path does not exist, it logs a warning and returns false. | ||
| // It also checks if the path is a file, in which case it checks the directory of the file. |
There was a problem hiding this comment.
I think the part about if path doesn't exist might cause issues when this PR goes in #1134. From my understanding a directory that does not exist can be refrenced
There was a problem hiding this comment.
Removed that portion so I'll update the comment, thanks!
dhurley
reviewed
Jul 4, 2025
| expected []string | ||
| }{ | ||
| { | ||
| name: "Empty path", |
There was a problem hiding this comment.
Can you update the format of the test names to
Test 1: Empty path
| // It returns true if the path is allowed, false otherwise. | ||
| // If the path is allowed but does not exist, it also logs a warning. | ||
| // It also checks if the path is a file, in which case it checks the directory of the file. | ||
| func isAllowedDir(path string, allowedDirs []string) bool { |
There was a problem hiding this comment.
Can you pass the context into this function as well so that we can use it in the log statements?
| directoryPath := path | ||
| isFilePath, err := regexp.MatchString(`\.(\w+)$`, directoryPath) | ||
| if err != nil { | ||
| slog.Error("Error matching path", "path", directoryPath, "error", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds some validation of paths when loading the allowed directories.
Allowed paths must:
.,..,etc)Any files not satisfying this criteria will be ignored, and logged at WARN level.
When checking if a path is allowed using
isAllowedDir, we will now check if the path exists and if it does we will perform a symlink check. Any symlinks will be logged and the function will return false.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)