-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JWT license information to NGINX App Protect WAF documentation #294
Comments
There's two include files with nearly identical information: https://github.com/nginx/documentation/blob/main/content/includes/licensing-and-reporting/download-jwt-crt-from-myf5.md The former is a bit more verbose, so I'm inclined to go with that - though I'm going to check NIM and N1C for what the most recent conventions are. The secondary step seems to be this text fragment: I think the quickest fix for this issue prior to rewriting each page will be to add this as a post-installation section to NGINX Plus set-up where relevant. |
On farther investigation, it looks like the first file is used commonly in NGINX Plus documentation, while the second file is more common in NGINX Instance Manager documentation. In the latter case, it's actually part of nested include files to create a more complex set of instructions. I'm not sure why both of these includes exist - I'm going to create a time box of two days for a consensus which to go with. It's outside the scope of this discrete issue, but we should consolidate them into one include for consistency. |
In an effort to reduce duplication of use cases, albeit requiring an extra hop, I think it would be best to explicitly direct users to the NGINX Plus documentation during set-up. NGINX Plus has a pattern of "heading for each operating system" while NGINX App Protect WAF has a pattern of "tab for each operating system". I find both awkward for different reasons, but I think headings are the lesser evil to tabs. Most of the NGINX Plus documentation coherently encapsulates the earliest steps of the NGINX Plus set-up steps for NGINX App Protect WAF: the only "extra" step is usually to add the NAP repository and install the package. Duplicate effort for maintenance: if I were to push through with trying to scope each product purely to their own instructions, I'd axe most of the NAP content:
It reduces the maintenance overhead on NAP, ensures the instructions remain updated by making sure there is only one copy. Since NGINX Plus is upstream for all commercial NGINX products, its documentation also tends to be updated the earliest. |
If possible, I’d recommend avoiding tabs—they add complexity to UX (especially on mobile) and increase content maintenance overhead. The syntax for tabs can also be a barrier for users unfamiliar with them. I’ve observed in user testing that NAP users struggle with completing tasks due to frequent hops between documentation. If directing users to NGINX Plus docs helps streamline this, it could work, but I’d like to test whether it actually reduces friction or introduces new navigation challenges. Would you be open to using headings instead of tabs while ensuring that any necessary NGINX Plus setup steps are summarized in-line before linking out? This might help users follow along without jumping back and forth too much. |
I'm absolutely all for removing the tabs - I plan to as part of the refactor effort. Since this is critical information I thought I would try to action it immediately, but investigating it has revealed larger scope issues around the way the installation documentation is structured. A swap to headings would make it similar in structure to the NGINX Plus documentation: if users are being redirected to another documentation set, then having them look similar should in theory create less cognitive dissonance. Of course, if the headings and structure match - maybe that's a case where includes can be used to cleanly replicate the critical information. Then the user doesn't need to hop, and we can ensure the instructions remain correct through only having to maintain the text fragments of the include. |
As a temporary fix, I have used the above includes to add a section just before the operating system tabs to give the user the context around downloading the license file. I think it technically fulfills the acceptance criteria for this issue, but I am contending that this is a compromise until we have had more time to restructure the NAP documentation. |
Ticking off the last bit of acceptance criteria:
That's a "commercial-subscription-sales-engineering" level of concern and not something product documentation contends with. I'm closing this issue, and associating it with the imminent NAP release. |
Overview
As a NGINX App Protect WAF user, I want information on adding my license file, So I can run NGINX App Protect WAF.
Description
This originally came in as a report from @aknot242 :
It's a common use case that has largely been "solved" for most of the NGINX product installation documentation. As a result, I think all of the information needed for this likely already exists in include files.
When I shared this perspective, @travisamartin offered some advice:
Steps
Acceptance criteria
The text was updated successfully, but these errors were encountered: