Skip to content

Update and clarify NGINX One RBAC docs #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2025
Merged

Update and clarify NGINX One RBAC docs #265

merged 3 commits into from
Mar 14, 2025

Conversation

tstraley
Copy link
Collaborator

@tstraley tstraley commented Mar 6, 2025

Proposed changes

Problem: Inaccuracies and confusing sentences in new RBAC docs for N1.

Solution: Reworded and revised for accuracy.

Testing: N/A

Please focus on (optional): N/A

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@tstraley tstraley requested a review from a team as a code owner March 6, 2025 23:33
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, two edit suggestions. The suggestion related to the use of inline HTML applies to the whole document, but I only addressed the lines within the scope of the PR.

@JTorreG JTorreG added the product/nginx-one NGINX One Console label Mar 11, 2025
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tstraley Thanks so much for clarifying! Next time, I'll include you in my list of reviewers. I've added some suggestions mostly to focus on the "second person", to make our recommendations more personal for the reader.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 12, 2025
@tstraley tstraley requested review from JTorreG and mjang March 12, 2025 20:03
@mjang mjang merged commit ac54abb into nginx:main Mar 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginx-one NGINX One Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants