-
Notifications
You must be signed in to change notification settings - Fork 54
Update and clarify NGINX One RBAC docs #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, two edit suggestions. The suggestion related to the use of inline HTML applies to the whole document, but I only addressed the lines within the scope of the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tstraley Thanks so much for clarifying! Next time, I'll include you in my list of reviewers. I've added some suggestions mostly to focus on the "second person", to make our recommendations more personal for the reader.
Proposed changes
Problem: Inaccuracies and confusing sentences in new RBAC docs for N1.
Solution: Reworded and revised for accuracy.
Testing: N/A
Please focus on (optional): N/A
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩