Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused ref to internal catalog #270

Merged
merged 3 commits into from
Mar 12, 2025
Merged

fix: remove unused ref to internal catalog #270

merged 3 commits into from
Mar 12, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Mar 11, 2025

Proposed changes

Problem: Current archetypes include unneeded info. Problem ID'd in this comment.

Solution: Remove unneded info

Testing: n/a

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@mjang mjang self-assigned this Mar 11, 2025
@mjang mjang requested a review from ADubhlaoich March 11, 2025 16:37
@github-actions github-actions bot added the tooling Back end, repository, Hugo, and all things not related to content label Mar 11, 2025
@mjang mjang marked this pull request as ready for review March 11, 2025 16:38
@mjang mjang requested a review from a team as a code owner March 11, 2025 16:38
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/270/

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is unnecessary, much like the other frontmatter fields, I kept it in as a reminder for the benefit of future documentation authors as something they may want to engage with, much like the existence of the toc field.

For future testing checks I intend to have a warning if this field does not exist, which will change to an error should the catalogue system resurface.

@mjang
Copy link
Contributor Author

mjang commented Mar 12, 2025

Although this is unnecessary, much like the other frontmatter fields, I kept it in as a reminder for the benefit of future documentation authors as something they may want to engage with, much like the existence of the toc field.

For future testing checks I intend to have a warning if this field does not exist, which will change to an error should the catalogue system resurface.

Cross that bridge when we come to it?

@mjang mjang merged commit dfc67ce into main Mar 12, 2025
9 checks passed
@mjang mjang deleted the update-archtypes branch March 12, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Back end, repository, Hugo, and all things not related to content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants