Skip to content

feat: Update NIM Security Monitoring front matter and reference links #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2025
Merged

feat: Update NIM Security Monitoring front matter and reference links #298

merged 2 commits into from
Mar 18, 2025

Conversation

ADubhlaoich
Copy link
Contributor

Proposed changes

This commit updates the Security Monitoring subsection of the NAP WAF documentation within NGINX Instance Manager to have contemporary frontmatter formatting, including a fixed url parameter for the index.

The previous URL parameter was causing some odd behaviour, with duplicate deployments of folders.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@ADubhlaoich
feat: Update NIM Security Monitoring front matter and reference links
914d3a5 
This commit updates the Security Monitoring subsection of the NAP WAF
documentation within NGINX Instance Manager to have contemporary
frontmatter formatting, including a fixed url parameter for the index.

The previous URL parameter was causing some odd behaviour, with
duplicate deployments of folders.
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner March 18, 2025 17:33
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim NGINX Instance Manager labels Mar 18, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/298/

@ADubhlaoich
Copy link
Contributor Author

Screenshot showing the fix:

image

@ADubhlaoich ADubhlaoich merged commit b62ab52 into main Mar 18, 2025
9 checks passed
@ADubhlaoich ADubhlaoich deleted the nim/move-security-monitoring-folder branch March 18, 2025 17:43
@travisamartin travisamartin mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisamartin travisamartin

@JTorreG JTorreG

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation product/nim NGINX Instance Manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ADubhlaoich @travisamartin @JTorreG