Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update NIM deploy helm doc #317

Merged
merged 1 commit into from
Mar 26, 2025
Merged

fix: update NIM deploy helm doc #317

merged 1 commit into from
Mar 26, 2025

Conversation

JTorreG
Copy link
Contributor

@JTorreG JTorreG commented Mar 26, 2025

Proposed changes

Fix yaml code block on the NIM Helm deploy document

Closes #1531

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@JTorreG JTorreG requested a review from a team as a code owner March 26, 2025 14:17
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim NGINX Instance Manager labels Mar 26, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/317/

@JTorreG JTorreG self-assigned this Mar 26, 2025
@mjang
Copy link
Contributor

mjang commented Mar 26, 2025

Based on info from the original issue, should this be reviewed by @jo-carter ?

Approving from a doc PoV.

@JTorreG JTorreG merged commit f99be74 into main Mar 26, 2025
9 checks passed
@JTorreG JTorreG deleted the issue-1531 branch March 26, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nim NGINX Instance Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants