-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the limitation 'Policies with modifications' in NIM #319
Conversation
Created few custom policies having 'modifications block' with various 'entityTypes'. Able to apply these policies to datapath instances in NIM. Hence removing this limitation.
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM: made an edit suggestion to replace the production URL link for the feature above the line removed with a Hugo reference, as is our norm.
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
Approving and merging. @travisamartin I think this is a fairly trivial change. Let me know if I overstepped. |
Created few custom policies having 'modifications block' with various 'entityTypes'. Able to apply these policies to datapath instances in NIM. Hence removing this limitation.
Proposed changes
Problem: The limitation ' Policies with modifications' has been present in NIM documentation.
Solution: This limitation needs to be removed from the docs as it is not valid anymore.
Testing: Created few custom policies having 'modifications block' with various 'entityTypes'. Able to apply these policies to datapath instances in NIM. Hence removing this limitation.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩