Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the limitation 'Policies with modifications' in NIM #319

Merged
merged 3 commits into from
Mar 27, 2025

Conversation

vvnginx
Copy link
Contributor

@vvnginx vvnginx commented Mar 27, 2025

Created few custom policies having 'modifications block' with various 'entityTypes'. Able to apply these policies to datapath instances in NIM. Hence removing this limitation.

Proposed changes

Problem: The limitation ' Policies with modifications' has been present in NIM documentation.

image

Solution: This limitation needs to be removed from the docs as it is not valid anymore.

Testing: Created few custom policies having 'modifications block' with various 'entityTypes'. Able to apply these policies to datapath instances in NIM. Hence removing this limitation.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

Created few custom policies having 'modifications block' with various 'entityTypes'. Able to apply these policies to datapath instances in NIM. Hence removing this limitation.
@vvnginx vvnginx requested a review from a team as a code owner March 27, 2025 09:55
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim NGINX Instance Manager labels Mar 27, 2025
Copy link

github-actions bot commented Mar 27, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@vvnginx vvnginx changed the title Remove the limitation 'Policies with modifications' Remove the limitation 'Policies with modifications' in NIM Mar 27, 2025
@vvnginx
Copy link
Contributor Author

vvnginx commented Mar 27, 2025

I have hereby read the F5 CLA and agree to its terms

@vvnginx
Copy link
Contributor Author

vvnginx commented Mar 27, 2025

recheck

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM: made an edit suggestion to replace the production URL link for the feature above the line removed with a Hugo reference, as is our norm.

Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
@mjang
Copy link
Contributor

mjang commented Mar 27, 2025

Approving and merging. @travisamartin I think this is a fairly trivial change. Let me know if I overstepped.

@mjang mjang merged commit 14d5690 into nginx:main Mar 27, 2025
6 checks passed
@vvnginx vvnginx deleted the patch-1 branch March 27, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nim NGINX Instance Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants