-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for granular API groups feature in NGINX One #370
Added documentation for granular API groups feature in NGINX One #370
Conversation
🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree: I have hereby read the F5 CLA and agree to its terms 1 out of 2 committers have signed the CLA. |
I have hereby read the F5 CLA and agree to its terms |
@kamalchaturvedi this references Namespace updates as well, Didn't think that was ready yet? |
Those are XC namespaces, as referred to in the intro section of this page: https://docs.nginx.com/nginx-one/rbac/rbac-api/
Would adding a note regarding N1 support for namespaces coming soon help with this ? I wanted to ensure we give user the knowledge of how namespaces can help them segregate these permissions. Otherwise, i am fine removing this line if it causes confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @kamalchaturvedi !
TLDR: I've tried to retain the essential info, while making the content easier to read. I also think that it's better to link to https://docs.nginx.com/nginx-one/rbac/rbac-api/.
Inote: if this doesn't work, I have privileges to override and merge this PR.) Kamal Chaturvedi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
I think Mike's changes are good. |
Based on @jasonclopper 's approval, I'll merge my changes and approve and merge. |
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Added changelog entry for already existing documentation for granular API groups in NGINX one.
Solution: N/A
Testing: Describe any testing that you did.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩