revert: undo globSync from fs #237
Merged
+365
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjohansebas
approved these changes
Mar 24, 2025
|
Wasnt the original PR also fixing some issue with Windows? |
|
I think you are thinking of #235, which was a different PR, also related to Windows. Both PRs fixed an issue with Windows. That one, a failed assertion |
|
What I recall is that the original PR has something “windows” on the PR title but I might be mistaken |
ovflowd
approved these changes
Mar 24, 2025
|
FWIW #228 (The original PR) stated "On Windows, using a backslash in the path (e.g., -i .\docs\buffer.md rather than -i ./docs/buffer.md) prevents the glob from matching correctly. This issue is resolved by using the fs version of globSync." in the description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @ovflowd