feat(linter): introduce raw ast rules #239
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivkeller
reviewed
Mar 28, 2025
src/linter/engine.mjs
Outdated
| issues.push(...rule(entries)); | ||
| issues.push(...rule(ast)); |
There was a problem hiding this comment.
WDYT about there being be a way for the linter to accept entries OR ast, depending on what it needs. For some scenarios, getting the AST may be preferable
Whatever you think is best
There was a problem hiding this comment.
I don't have a strong opinion about this, I can make a simple test so we can decide what is the best option.
|
I refactored the |
AugustinMauroy
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validation
Related Issues
Check List