-
Notifications
You must be signed in to change notification settings - Fork 9
feat(cli): split cli into sub commands #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ack! I never rebased the multi-threading |
a775195
to
f2ebf8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review on things I need to verify/fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a DX point of view, do we want to have commands that are just keyword like list
or should they all be flags like --list
?
I'm fine with both
As @ovflowd stated in the linked issue,
I like the idea of splitting each different function into these subcommands, I feel it makes it easier to understand what does what. |
14707bc
to
0255fb6
Compare
Co-authored-by: flakey5 <73616808+flakey5@users.noreply.github.com>
Requesting review from @ovflowd, who opened the issue |
…docs-tooling into feat/cli/subcommands
Description
This PR splits the CLI into subcommands, following the structure shown below:
Validation
Every command shown in the updated README should work as intended.
Related Issues
Fixes #148
Check List