-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module: improve typescript error message format #57598
Open
nodejs-github-bot
wants to merge
2
commits into
main
Choose a base branch
from
actions/tools-update-amaro
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Review requested:
|
aduh95
approved these changes
Mar 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57598 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 630 630
Lines 185129 185147 +18
Branches 36234 36230 -4
==========================================
+ Hits 167049 167065 +16
- Misses 11037 11040 +3
+ Partials 7043 7042 -1
🚀 New features to boost your workflow:
|
RafaelGSS
approved these changes
Mar 23, 2025
legendecas
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
dependencies
Pull requests that update a dependency file.
lib / src
Issues and PRs related to general changes in the lib or src directory.
module
Issues and PRs related to the module subsystem.
needs-ci
PRs that need a full CI run.
request-ci
Add this label to start a Jenkins CI on a PR.
strip-types
Issues or PRs related to strip-types support
wip
Issues and PRs that are still a work in progress.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of amaro to 0.5.0.
Fixes: #56830
This PR improves the error messages generated by the transpiler.
Node.js v23.9.0:
This PR:
It removes the internal file path:
Removes the padding boxing the message:
In general it blends better with Node.js error style.
There is still an improvement to make that involves removing the whitespace around:
This depends from SWC and its currently being fixed.