fix: Fix OOB array access in runPasses (AssemblyScript#1592)

dcodeIO · web-flow · commit f31451246a55 · 2020-12-19T09:49:53.000+01:00
diff --git a/src/module.ts b/src/module.ts
@@ -1486,7 +1486,7 @@ export class Module {
       binaryen._BinaryenModuleRunPasses(this.ref, cArr, numNames);
     }
     binaryen._free(cArr);
-    for (let i = numNames; i >= 0; --i) binaryen._free(cStrs[i]);
+    for (let i = numNames - 1; i >= 0; --i) binaryen._free(cStrs[i]);
   }
 
   optimize(optimizeLevel: i32, shrinkLevel: i32, debugInfo: bool = false, usesARC: bool = true): void {

Original file line number	Diff line number	Diff line change
`@@ -1486,7 +1486,7 @@ export class Module {`
`1486`	`1486`	`binaryen._BinaryenModuleRunPasses(this.ref, cArr, numNames);`
`1487`	`1487`	`}`
`1488`	`1488`	`binaryen._free(cArr);`
`1489`		`- for (let i = numNames; i >= 0; --i) binaryen._free(cStrs[i]);`
	`1489`	`+ for (let i = numNames - 1; i >= 0; --i) binaryen._free(cStrs[i]);`
`1490`	`1490`	`}`
`1491`	`1491`
`1492`	`1492`	`optimize(optimizeLevel: i32, shrinkLevel: i32, debugInfo: bool = false, usesARC: bool = true): void {`