Logistic Regression-patch2 #3377
Open
+457
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzegla
added
the
GSoC
mzegla
requested changes
Jun 20, 2025
Co-authored-by: Miłosz Żeglarski <milosz.zeglarski@intel.com>
Co-authored-by: Miłosz Żeglarski <milosz.zeglarski@intel.com>
mzegla
reviewed
Jul 8, 2025
Comment on lines
+41
to
+42
| if inp_bytes[:1] != b'{' and inp_bytes.find(b'{') > 0: | ||
| first_brace = inp_bytes.find(b'{') |
There was a problem hiding this comment.
I can see you run find twice. I suppose you can run it once before the check and store the value.
Also I'm not sure if you need first part of the condition: inp_bytes[:1] != b'{'. If you search entire inp_bytes with find, there's no need for a separate check I guess.
mzegla
reviewed
Jul 10, 2025
| from sklearn.utils import shuffle | ||
| import os | ||
|
|
||
| os.makedirs("data_folder", exist_ok=True) |
There was a problem hiding this comment.
Let's not implicitly create directories in user filesystem. Instead we could accept script parameter with path to the catalog where we would save the data.
mzegla
reviewed
Jul 10, 2025
Comment on lines
+3
to
+5
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
No need for so many newlines
mzegla
reviewed
Jul 10, 2025
Comment on lines
+11
to
+12
|
|
||
| WORKDIR /workspace |
There was a problem hiding this comment.
Suggested change
| WORKDIR /workspace |
That's obsolete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
Logistic Regression-ver2